Closed Bug 1036484 Opened 8 years ago Closed 8 years ago

No error on empty 404

Categories

(Core :: DOM: Workers, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: evilpie, Assigned: baku)

References

Details

Attachments

(1 file)

I just spent a ridiculous amount of time figuring out why the Worker onerror callback wasn't invoked. Turns out when you send a completely blank 404 as worker scripts, onerror isn't invoked. (Content-Lenght: 0) However most webserver send some HTML, which doesn't validate as JS and thus an error is thrown. I don't know the spec for Workers, but I would expect this to thrown an error.
Andrea would you be interested in investigating this?
Flags: needinfo?(amarchesini)
Attached patch empty404.patchSplinter Review
Attachment #8470470 - Flags: review?(khuey)
Flags: needinfo?(amarchesini)
Comment on attachment 8470470 [details] [diff] [review]
empty404.patch

Review of attachment 8470470 [details] [diff] [review]:
-----------------------------------------------------------------

That was a surprisingly effective needinfo request.
Attachment #8470470 - Flags: review?(khuey) → review+
https://tbpl.mozilla.org/?tree=Try&rev=5dbceee138ec
Assignee: nobody → amarchesini
https://hg.mozilla.org/mozilla-central/rev/a40fb5d2a1aa
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify-
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.