1036484 - No error on empty 404

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Tom S. (please needinfo tschuster)]

I just spent a ridiculous amount of time figuring out why the Worker onerror callback wasn't invoked. Turns out when you send a completely blank 404 as worker scripts, onerror isn't invoked. (Content-Lenght: 0) However most webserver send some HTML, which doesn't validate as JS and thus an error is thrown. I don't know the spec for Workers, but I would expect this to thrown an error.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Andrea would you be interested in investigating this?

Comment 2

[Andrea Marchesini [:baku]]

Attachment: empty404.patch

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8470470 [details] [diff] [review]
empty404.patch

Review of attachment 8470470 [details] [diff] [review]:
-----------------------------------------------------------------

That was a surprisingly effective needinfo request.

Comment 4

[Andrea Marchesini [:baku]]

https://tbpl.mozilla.org/?tree=Try&rev=5dbceee138ec

Comment 5

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a40fb5d2a1aa

Comment 6

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/mozilla-central/rev/a40fb5d2a1aa