1036495 - adjust the app UUID in ids.json to be unique for reviewers and between app versions.

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Reviewer Tools, defect, P3)

Description

[Andrew Williamson [:eviljeff]]

Similar to bug 974659, but on Desktop - and this time I'd un-installed previous versions first.

Error installing webapp: WRONG_APP_STORE_ID WebappManager.jsm:147
A promise chain failed to handle a rejection.

Comment 1

[Andrew Williamson [:eviljeff]]

I think now this is a problem on platform rather than Marketplace.
Background - I had the iframe installed previously and forgot to uninstall it before attempting another installation.  Now, even after installing (and deleting the folder) it refuses to install again.

Comment 2

[Andrew Williamson [:eviljeff]]

Attachment: my webapps.json

attaching my webapps.json for reference.

Comment 3

[Marco Castelluccio [:marco]]

Is the app https://marketplace.firefox.com/reviewers/apps/review/iframe ? I can't reproduce on Linux.

Could you provide precise steps to reproduce? Can you reproduce in a clean profile?

Comment 4

[Andrew Williamson [:eviljeff]]

I can't(In reply to Marco Castelluccio [:marco] from comment #3)
> Is the app https://marketplace.firefox.com/reviewers/apps/review/iframe ? 

yes

> Could you provide precise steps to reproduce? Can you reproduce in a clean
> profile?

I can't.  I tried with a sample app on -dev to see if the different versions caused it (i.e. upload version 1; install version 1; approve; upload version 2; install version 2;) but hit a different (and probably unconnected) bug with -dev.

Comment 5

[Marco Castelluccio [:marco]]

OK, the problem is with your profile. You have three IFrame apps in your profile, with three different manifest URLs (https://marketplace.firefox.com/reviewers/iframe-1/1542675/mini-manifest, https://marketplace.firefox.com/reviewers/iframe/1543665/mini-manifest and https://marketplace.firefox.com/reviewers/iframe/1544473/mini-manifest). Let's call them A, B, C.

A has the correct storeId, B and C have a storeId=="". 

When you try to reinstall the app B, now with the correct storeId, we find app A that has the same storeId and so we throw WRONG_APP_STORE_ID.

I suppose something wrong happened with the Marketplace, since it's serving app B with the same storeId as app A but with a different manifest URL.

Comment 6

[Marco Castelluccio [:marco]]

Attachment: Patch

This patch should avoid this problem, could you try it?

Comment 7

[Marco Castelluccio [:marco]]

(For storeId matching, it's going to consider only apps that are natively installed)

Comment 8

[Andrew Williamson [:eviljeff]]

(In reply to Marco Castelluccio [:marco] from comment #6)
> Created attachment 8454585 [details] [diff] [review]
> Patch
> 
> This patch should avoid this problem, could you try it?

I don't have the build enviroment (nor the recent experience) to be able to apply the patch I'm afraid.

Comment 9

[Andrew Williamson [:eviljeff]]

(In reply to Marco Castelluccio [:marco] from comment #5)
> OK, the problem is with your profile. You have three IFrame apps in your
> profile, with three different manifest URLs
> (https://marketplace.firefox.com/reviewers/iframe-1/1542675/mini-manifest,
> https://marketplace.firefox.com/reviewers/iframe/1543665/mini-manifest and
> https://marketplace.firefox.com/reviewers/iframe/1544473/mini-manifest).
> Let's call them A, B, C.
> 
> A has the correct storeId, B and C have a storeId=="". 
> 
> When you try to reinstall the app B, now with the correct storeId, we find
> app A that has the same storeId and so we throw WRONG_APP_STORE_ID.
> 
> I suppose something wrong happened with the Marketplace, since it's serving
> app B with the same storeId as app A but with a different manifest URL.

So Marketplace sets this store ID?  How is it communicated - I don't see it in the mini-manifest.

Comment 10

[Marco Castelluccio [:marco]]

(In reply to Andrew Williamson [:eviljeff] from comment #9)
> (In reply to Marco Castelluccio [:marco] from comment #5)
> > OK, the problem is with your profile. You have three IFrame apps in your
> > profile, with three different manifest URLs
> > (https://marketplace.firefox.com/reviewers/iframe-1/1542675/mini-manifest,
> > https://marketplace.firefox.com/reviewers/iframe/1543665/mini-manifest and
> > https://marketplace.firefox.com/reviewers/iframe/1544473/mini-manifest).
> > Let's call them A, B, C.
> > 
> > A has the correct storeId, B and C have a storeId=="". 
> > 
> > When you try to reinstall the app B, now with the correct storeId, we find
> > app A that has the same storeId and so we throw WRONG_APP_STORE_ID.
> > 
> > I suppose something wrong happened with the Marketplace, since it's serving
> > app B with the same storeId as app A but with a different manifest URL.
> 
> So Marketplace sets this store ID?  How is it communicated - I don't see it
> in the mini-manifest.

It's in the zip file, META-INF/ids.json.

(In reply to Andrew Williamson [:eviljeff] from comment #8)
> (In reply to Marco Castelluccio [:marco] from comment #6)
> > Created attachment 8454585 [details] [diff] [review]
> > Patch
> > 
> > This patch should avoid this problem, could you try it?
> 
> I don't have the build enviroment (nor the recent experience) to be able to
> apply the patch I'm afraid.

I'll produce a try build for you to test.

Comment 11

[Andrew Williamson [:eviljeff]]

(In reply to Marco Castelluccio [:marco] from comment #10)
> (In reply to Andrew Williamson [:eviljeff] from comment #9)
> > (In reply to Marco Castelluccio [:marco] from comment #5)
> > > OK, the problem is with your profile. You have three IFrame apps in your
> > > profile, with three different manifest URLs
> > > (https://marketplace.firefox.com/reviewers/iframe-1/1542675/mini-manifest,
> > > https://marketplace.firefox.com/reviewers/iframe/1543665/mini-manifest and
> > > https://marketplace.firefox.com/reviewers/iframe/1544473/mini-manifest).
> > > Let's call them A, B, C.
> > > 
> > > A has the correct storeId, B and C have a storeId=="". 
> > > 
> > > When you try to reinstall the app B, now with the correct storeId, we find
> > > app A that has the same storeId and so we throw WRONG_APP_STORE_ID.
> > > 
> > > I suppose something wrong happened with the Marketplace, since it's serving
> > > app B with the same storeId as app A but with a different manifest URL.
> > 
> > So Marketplace sets this store ID?  How is it communicated - I don't see it
> > in the mini-manifest.
> 
> It's in the zip file, META-INF/ids.json.

thanks.  it appears versions of reviewer signed addons are given a unique mini-manifest url (based on the version ID I believe) but a non-unique ID in META-INF/ids.json. One of these needs to change...

Comment 12

[Marco Castelluccio [:marco]]

Here's the try build: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-18a8031e4a08/

Comment 13

[Rob Hudson [:robhudson]]

For reviewer installed apps we can adjust the app UUID in ids.json to be unique for reviewers and between app versions. This will help both to keep the app unique against the app installed via consumer pages, and also unique between versions.

Proposal: If installed by a reviewer, set UUID to something like "reviewer-<UUID>-<version.pk>".

Comment 14

[Andrew Williamson [:eviljeff]]

I'm hitting bug 1039520 now so can't test your try (without uploading test apps on production Marketplace, which I'd rather not do...)

Comment 15

[Marco Castelluccio [:marco]]

(In reply to Andrew Williamson [:eviljeff] from comment #14)
> I'm hitting bug 1039520 now so can't test your try (without uploading test
> apps on production Marketplace, which I'd rather not do...)

Are you hitting that bug on -dev?

Comment 16

[Andrew Williamson [:eviljeff]]

(In reply to Marco Castelluccio [:marco] from comment #15)
> (In reply to Andrew Williamson [:eviljeff] from comment #14)
> > I'm hitting bug 1039520 now so can't test your try (without uploading test
> > apps on production Marketplace, which I'd rather not do...)
> 
> Are you hitting that bug on -dev?

yes.

Comment 17

[Andrew Williamson [:eviljeff]]

moving this to Marketplace as comments indicate its due to Marketplace's method of generating mini-manifests.

Comment 18

[Andrew Williamson [:eviljeff]]

see comment #13

Comment 19

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/9ea2e4e 

Verify that you can install the same app onto the same device -- once as a public app from the consumer pages, and once from the reviewer tools. For bonus points, verify you can install multiple versions of the same app (e.g. v1.0 from reviewer tools, and v1.1 from reviewer tools).

Comment 20

[Andrew Williamson [:eviljeff]]

(In reply to Rob Hudson [:robhudson] from comment #19)
> For
> bonus points, verify you can install multiple versions of the same app (e.g.
> v1.0 from reviewer tools, and v1.1 from reviewer tools).

How is that actually done?

Comment 21

[Rob Hudson [:robhudson]]

(In reply to Andrew Williamson [:eviljeff] from comment #20)
> (In reply to Rob Hudson [:robhudson] from comment #19)
> > For
> > bonus points, verify you can install multiple versions of the same app (e.g.
> > v1.0 from reviewer tools, and v1.1 from reviewer tools).
> 
> How is that actually done?

If you had v1.0 already on your phone and v1.1 was uploaded by the developer you should be able to install v1.1 w/o app store ID conflict.

Comment 22

[Andrew Williamson [:eviljeff]]

so there isn't any GUI to do this? i.e. its only possible if you happened to install the previous version and keep it on the device, and then do the same after the developer has uploaded a new version?

New bug?

Comment 23

[Iulian Timis]

Please add STR here or mark it with [qa-] if no QA is needed.

Comment 24

[Rob Hudson [:robhudson]]

(In reply to Iulian Timis from comment #23)
> Please add STR here or mark it with [qa-] if no QA is needed.

Yes, please verify that you can install the same app onto the same device -- once as a public app from the consumer pages, and once from the reviewer tools.

Comment 25

[Rob Hudson [:robhudson]]

(In reply to Andrew Williamson [:eviljeff] from comment #22)
> so there isn't any GUI to do this? i.e. its only possible if you happened to
> install the previous version and keep it on the device, and then do the same
> after the developer has uploaded a new version?
> 
> New bug?

I believe there was a bug a long time ago to be able to install older versions. It is possible to QA this as-is but let's just skip it as it sounds like an edge case.

Comment 26

[Iulian Timis]

Verified as fixed on FF35 (Android 4.2.1). When I try to install the same app from Reviewer Tools, it sais that the app is updating.
On Inari 1.4, I have installed an app from the Consumer Pages, but when I try to install the same app from Reviewer Tools, I get "Install failed. Please try again later".

Comment 27

[Rob Hudson [:robhudson]]

(In reply to Iulian Timis from comment #26)
> Verified as fixed on FF35 (Android 4.2.1). When I try to install the same
> app from Reviewer Tools, it sais that the app is updating.
> On Inari 1.4, I have installed an app from the Consumer Pages, but when I
> try to install the same app from Reviewer Tools, I get "Install failed.
> Please try again later".

Is it possible to get the failure log from adb logcat to know how it failed? Thanks.

Comment 28

[Iulian Timis]

Attachment: install_fail.txt

Comment 29

[Rob Hudson [:robhudson]]

Thanks. It looks like it is related to receipts.

E/GeckoConsole(  443): Content JS LOG at app://packaged.marketplace.allizom.org/media/js/include.js:6 in s/<: [req] Request failed: POST 402
E/GeckoConsole(  443): Content JS ERROR at app://packaged.marketplace.allizom.org/media/js/include.js:6 in s/<: [buttons] Could not generate receipt or record install for Test App (tier80)

Comment 30

[Rob Hudson [:robhudson]]

(In reply to Iulian Timis from comment #28)
> Created attachment 8504798 [details]
> install_fail.txt

Iulian -- can you explain how you are testing? Which app are you using? How are you installing (via the app or browser)? I see 2 failures in the logs and they look the same to me.

Comment 31

[krupa raj[:krupa]]

reopened based on comments 28 and 30

Comment 32

[Iulian Timis]

I have installed the app Test App (peccary5373) from the MP-stage app and then I loaded the MP-stage Reviewer Tools in the browser and tried to install the app from there.