1036501 - Don't auto-unwrap scripted direct proxies when calling non-generic functions

Status: RESOLVED DUPLICATE of bug 1111243

(Core :: JavaScript Engine, defect)

Description

[Till Schneidereit [:till]]

As discussed on IRC, we don't want to auto-unwrap scripted proxies when calling non-generic methods. We already don't do this for scripted indirect proxies, and this patch does the same for direct ones.

Comment 1

[Till Schneidereit [:till]]

Attachment: Don't auto-unwrap scripted direct proxies when calling non-generic functions

Comment 2

[Till Schneidereit [:till]]

Oh, and try-servering here just in case we have code somewhere that relies on this: https://tbpl.mozilla.org/?tree=Try&rev=a7987ee85bbe

Comment 3

[Till Schneidereit [:till]]

Comment on attachment 8453161 [details] [diff] [review]
Don't auto-unwrap scripted direct proxies when calling non-generic functions

Switching reviewer: efaust offered on IRC and has the shorter review queue.

Comment 4

[Eric Faust [:efaust]]

Comment on attachment 8453161 [details] [diff] [review]
Don't auto-unwrap scripted direct proxies when calling non-generic functions

Review of attachment 8453161 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=me

::: js/src/jsproxy.cpp
@@ +1096,5 @@
>      /* Spidermonkey extensions. */
>      virtual bool call(JSContext *cx, HandleObject proxy, const CallArgs &args) const MOZ_OVERRIDE;
>      virtual bool construct(JSContext *cx, HandleObject proxy, const CallArgs &args) const MOZ_OVERRIDE;
> +    virtual bool nativeCall(JSContext *cx, IsAcceptableThis test, NativeImpl impl,
> +                            CallArgs args) const MOZ_OVERRIDE;

Just put the call to BaseProxyHandler::native call inline in the class definition like the other two. We really would love "using" here, but it doesn't play nicely with virtual functions.

Comment 5

[André Bargull [:anba]]

Also fixed in bug 1111243.