1036561 - Reduce log spam from SharedBufferManagerChild

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Sotaro Ikeda [:sotaro]]

SharedBufferManagerChild::GetGraphicBuffer() log outs the following log when key is invalid.
> Gecko   : SharedBufferManagerChild::GetGraphicBuffer -- invalid key

But the GetGraphicBuffer() is called from the following to confirm the key is invalid. Therefore each gralloc buffer allocation in content process print the log :-(

http://mxr.mozilla.org/mozilla-central/source/gfx/layers/ipc/ShadowLayerUtilsGralloc.cpp#152

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Reduce log spam from SharedBufferManagerChild

Comment 2

[Sotaro Ikeda [:sotaro]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a60165250783

Comment 3

[Sotaro Ikeda [:sotaro]]

Nominate to b2g-v2.0. A lot of the following logs are very annoying and could cause misunderstanding.

>> Gecko   : SharedBufferManagerChild::GetGraphicBuffer -- invalid key

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a60165250783

Comment 5

[bhavana bajaj [:bajaj]]

(In reply to Sotaro Ikeda [:sotaro] from comment #3)
> Nominate to b2g-v2.0. A lot of the following logs are very annoying and
> could cause misunderstanding.
> 
> >> Gecko   : SharedBufferManagerChild::GetGraphicBuffer -- invalid key

Can you seek aurora approval here? Not something we would block the release on, but will be fine to uplift.

Comment 6

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8453260 [details] [diff] [review]
patch - Reduce log spam from SharedBufferManagerChild

Approval Request Comment
[Feature/regressing bug #]: Bug 1034294
[User impact if declined]:on gonk, false alarm logs are printed for each graphic buffer allocation. 
[Describe test coverage new/current, TBPL]:
[Risks and why]: Minimal - logging only change.
[String/UUID change made/needed]:None

Comment 7

[bhavana bajaj [:bajaj]]

Comment on attachment 8453260 [details] [diff] [review]
patch - Reduce log spam from SharedBufferManagerChild

low risk change during logging, approving for uplift.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0e6ed467cb4d