Closed Bug 1036561 Opened 10 years ago Closed 10 years ago

Reduce log spam from SharedBufferManagerChild

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Version:
32 Branch
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla33
Project Flags:
blocking-b2g -
Tracking Flags:
Tracking Status
firefox31 --- wontfix
firefox32 --- fixed
firefox33 --- fixed
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file)

patch - Reduce log spam from SharedBufferManagerChild
2.77 KB, patch
nical
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review
SharedBufferManagerChild::GetGraphicBuffer() log outs the following log when key is invalid. > Gecko : SharedBufferManagerChild::GetGraphicBuffer -- invalid key But the GetGraphicBuffer() is called from the following to confirm the key is invalid. Therefore each gralloc buffer allocation in content process print the log :-( http://mxr.mozilla.org/mozilla-central/source/gfx/layers/ipc/ShadowLayerUtilsGralloc.cpp#152
Attachment #8453260 - Flags: review?(nical.bugzilla)
Attachment #8453260 - Flags: review?(nical.bugzilla) → review+
Assignee: nobody → sotaro.ikeda.g
Nominate to b2g-v2.0. A lot of the following logs are very annoying and could cause misunderstanding. >> Gecko : SharedBufferManagerChild::GetGraphicBuffer -- invalid key
blocking-b2g: --- → 2.0?
Blocks: 1034294
No longer depends on: 1034294
https://hg.mozilla.org/mozilla-central/rev/a60165250783
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
(In reply to Sotaro Ikeda [:sotaro] from comment #3) > Nominate to b2g-v2.0. A lot of the following logs are very annoying and > could cause misunderstanding. > > >> Gecko : SharedBufferManagerChild::GetGraphicBuffer -- invalid key Can you seek aurora approval here? Not something we would block the release on, but will be fine to uplift.
blocking-b2g: 2.0? → -
Flags: needinfo?(sotaro.ikeda.g)
Comment on attachment 8453260 [details] [diff] [review] patch - Reduce log spam from SharedBufferManagerChild Approval Request Comment [Feature/regressing bug #]: Bug 1034294 [User impact if declined]:on gonk, false alarm logs are printed for each graphic buffer allocation. [Describe test coverage new/current, TBPL]: [Risks and why]: Minimal - logging only change. [String/UUID change made/needed]:None
Attachment #8453260 - Flags: approval-mozilla-aurora?
Flags: needinfo?(sotaro.ikeda.g)
Comment on attachment 8453260 [details] [diff] [review] patch - Reduce log spam from SharedBufferManagerChild low risk change during logging, approving for uplift.
Attachment #8453260 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: