Closed
Bug 1036619
Opened 11 years ago
Closed 11 years ago
Implement 1035394 - Add dangerous public destructor detection to _INHERITED refcounting macros in comm-central
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 33.0
People
(Reporter: rkent, Assigned: jcranmer)
References
Details
Attachments
(1 file, 1 obsolete file)
|
61.27 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
Bug 1035394 - Add dangerous public destructor detection to _INHERITED refcounting macros
|
Reporter | |
Comment 1•11 years ago
|
||
I'll try to work some of these issues in comm-central, but my progress so far has been slow (because of other comm-central build issues). Feel free to make progress independent of me if you like.
|
Assignee | |
Comment 2•11 years ago
|
||
Mork gets a dangerous public destructor because I am so not going there.
|
|
Assignee | |
Comment 3•11 years ago
|
||
Try found some problems with the last patch. Hopefully this fixes them.
Attachment #8453549 -
Attachment is obsolete: true
Attachment #8453549 -
Flags: review?(neil)
Attachment #8453567 -
Flags: review?(neil)
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8453567 [details] [diff] [review]
Second verse, same as the first
(I've replied to dholbert's original newsgroup post asking when to use protected or private and virtual or nonvirtual destructors and will file a followup bug if appropriate.)
Attachment #8453567 -
Flags: review?(neil) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 33.0
|
|
Assignee | |
Updated•10 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•