Implement 1035394 - Add dangerous public destructor detection to _INHERITED refcounting macros in comm-central

RESOLVED FIXED in Thunderbird 33.0

Status

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: rkent, Assigned: jcranmer)

Tracking

Trunk
Thunderbird 33.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Bug 1035394 - Add dangerous public destructor detection to _INHERITED refcounting macros
(Reporter)

Updated

5 years ago
Blocks: 1035394
(Reporter)

Comment 1

5 years ago
I'll try to work some of these issues in comm-central, but my progress so far has been slow (because of other comm-central build issues). Feel free to make progress independent of me if you like.
(Assignee)

Comment 2

5 years ago
Created attachment 8453549 [details] [diff] [review]
Second verse, same as the first

Mork gets a dangerous public destructor because I am so not going there.
Assignee: nobody → Pidgeot18
Status: NEW → ASSIGNED
Attachment #8453549 - Flags: review?(neil)
(Assignee)

Comment 3

5 years ago
Created attachment 8453567 [details] [diff] [review]
Second verse, same as the first

Try found some problems with the last patch. Hopefully this fixes them.
Attachment #8453549 - Attachment is obsolete: true
Attachment #8453549 - Flags: review?(neil)
Attachment #8453567 - Flags: review?(neil)
Comment on attachment 8453567 [details] [diff] [review]
Second verse, same as the first

(I've replied to dholbert's original newsgroup post asking when to use protected or private and virtual or nonvirtual destructors and will file a followup bug if appropriate.)
Attachment #8453567 - Flags: review?(neil) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/comm-central/rev/43010e7a79b9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 33.0
(Assignee)

Updated

4 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.