Closed Bug 1036619 Opened 10 years ago Closed 10 years ago

Implement 1035394 - Add dangerous public destructor detection to _INHERITED refcounting macros in comm-central

Categories

(MailNews Core :: Backend, defect)

Product:
MailNews Core
Component:
Backend
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 33.0

People

(Reporter: rkent, Assigned: jcranmer)

References

Details

Attachments

(1 file, 1 obsolete file)

Second verse, same as the first
61.27 KB, patch
neil
: review+
Details | Diff | Splinter Review 
Bug 1035394 - Add dangerous public destructor detection to _INHERITED refcounting macros
Blocks: 1035394
I'll try to work some of these issues in comm-central, but my progress so far has been slow (because of other comm-central build issues). Feel free to make progress independent of me if you like.
Attached patch Second verse, same as the first (obsolete) — — Splinter Review 
Mork gets a dangerous public destructor because I am so not going there.
Assignee: nobody → Pidgeot18
Status: NEW → ASSIGNED
Attachment #8453549 - Flags: review?(neil)
Try found some problems with the last patch. Hopefully this fixes them.
Attachment #8453549 - Attachment is obsolete: true
Attachment #8453549 - Flags: review?(neil)
Attachment #8453567 - Flags: review?(neil)
Comment on attachment 8453567 [details] [diff] [review]
Second verse, same as the first

(I've replied to dholbert's original newsgroup post asking when to use protected or private and virtual or nonvirtual destructors and will file a followup bug if appropriate.)
Attachment #8453567 - Flags: review?(neil) → review+
https://hg.mozilla.org/comm-central/rev/43010e7a79b9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 33.0
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: