1036691 - Firefox desktop no longer works with gaia

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Sudheesh Singanamalla (:ShellHacker)]

STR (https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Different_ways_to_run_Gaia#B2G_Desktop)

1. Path to b2g
2. DEBUG=1 DESKTOP=0 make
3. ./b2g /path/to/gaia/profile

Expected : Should run gaia

What happened :
```
$ /Applications/FirefoxNightly.app/Contents/MacOS/firefox -profile /Users/sudheeshsinganamalla/Documents/gaia/profile-debug
2147942487JavaScript error: http://system.gaiamobile.org:8080/shared/js/dump.js, line 24: settings is null
JavaScript error: http://system.gaiamobile.org:8080/js/applications.js, line 85: apps.mgmt is null
JavaScript error: http://system.gaiamobile.org:8080/shared/js/settings_listener.js, line 28: settings is null
JavaScript error: http://system.gaiamobile.org:8080/shared/js/idletimer.js, line 101: navigator.addIdleObserver is not a function
JavaScript error: http://system.gaiamobile.org:8080/shared/js/settings_listener.js, line 28: settings is null
JavaScript error: http://system.gaiamobile.org:8080/shared/js/settings_listener.js, line 28: settings is null
JavaScript error: http://system.gaiamobile.org:8080/js/icc.js, line 112: window.navigator.mozSettings is null
JavaScript error: http://system.gaiamobile.org:8080/js/airplane_mode.js, line 17: window.navigator.mozSettings is null
JavaScript error: http://system.gaiamobile.org:8080/js/cell_broadcast_system.js, line 15: settings is null
JavaScript error: http://system.gaiamobile.org:8080/js/value_selector/value_selector.js, line 82: navigator.mozSettings is null
JavaScript error: http://system.gaiamobile.org:8080/js/nfc_handover_manager.js, line 134: this.bluetooth is undefined
JavaScript error: http://system.gaiamobile.org:8080/js/operator_variant/operator_variant_iccs.js, line 73: _settings is null
JavaScript error: http://system.gaiamobile.org:8080/shared/js/settings_listener.js, line 28: settings is null
JavaScript error: http://system.gaiamobile.org:8080/js/call_forwarding.js, line 207: CallForwarding is not defined
JavaScript error: http://system.gaiamobile.org:8080/js/findmydevice_launcher.js, line 18: navigator.mozSettings is null
JavaScript error: http://system.gaiamobile.org:8080/js/newsletter_manager.js, line 103: navigator.addIdleObserver is not a function
JavaScript error: http://system.gaiamobile.org:8080/shared/js/settings_listener.js, line 28: settings is null
```

Also why is the number `2147942487` generated ?

My git log says the latest commit is 4233e61019794e3bcd35c3aa5b80c6211e1be652

Comment 1

[Nicholas Camp Barcellos]

I have this bug too. Firefox Nightly 35.0a1, Manjaro Linux (Arch based distro) x64.

[nicholascamp@manjaro ~]$ /usr/bin/firefox-nightly -profile /home/nicholascamp/projetos/gaia/profile-debug --no-remote

(process:22628): GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed
browser-helper: Something went wrong while trying to start browser-helper: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm -> file:///home/nicholascamp/projetos/gaia/profile-debug/extensions/[e-mail]/bootstrap.js :: startup :: line 134"  data: no]
2147942487JavaScript error: app://system.gaiamobile.org/shared/js/dump.js, line 24: settings is null
JavaScript error: app://system.gaiamobile.org/js/applications.js, line 85: apps.mgmt is undefined
JavaScript error: app://system.gaiamobile.org/shared/js/date_time_helper.js, line 33: window.navigator.mozSettings is null
JavaScript error: app://system.gaiamobile.org/shared/js/settings_listener.js, line 28: settings is null
JavaScript error: app://system.gaiamobile.org/js/icc.js, line 112: window.navigator.mozSettings is null
JavaScript error: app://system.gaiamobile.org/js/cell_broadcast_system.js, line 15: settings is null
JavaScript error: app://system.gaiamobile.org/js/operator_variant/operator_variant_iccs.js, line 73: _settings is null
JavaScript error: app://system.gaiamobile.org/shared/js/idletimer.js, line 101: navigator.addIdleObserver is not a function
JavaScript error: app://system.gaiamobile.org/shared/js/settings_listener.js, line 28: settings is null
JavaScript error: app://system.gaiamobile.org/js/airplane_mode.js, line 17: window.navigator.mozSettings is null
JavaScript error: app://system.gaiamobile.org/shared/js/settings_listener.js, line 28: settings is null
LogShake: starting captureLogs listener
JavaScript error: app://system.gaiamobile.org/js/call_forwarding.js, line 207: CallForwarding is not defined
JavaScript error: app://system.gaiamobile.org/js/findmydevice_launcher.js, line 32: navigator.mozSettings is null
JavaScript error: app://system.gaiamobile.org/js/newsletter_manager.js, line 103: navigator.addIdleObserver is not a function
JavaScript error: app://system.gaiamobile.org/shared/js/settings_listener.js, line 28: settings is null
JavaScript error: app://system.gaiamobile.org/js/internet_sharing.js, line 69: settings is null
JavaScript error: app://callscreen.gaiamobile.org/shared/js/date_time_helper.js, line 33: window.navigator.mozSettings is null
JavaScript error: app://callscreen.gaiamobile.org/js/call_screen.js, line 245: Argument 1 is not valid for any of the 2-argument overloads of URL.createObjectURL.

Comment 2

[Nicholas Camp Barcellos]

I can't run it in Firefox Aurora too:

[nicholascamp@manjaro gaia]$ /usr/local/bin/firefox-aurora -profile /home/nicholascamp/projetos/gaia/profile-debug --no-remote

(process:24492): GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed
1409950370833	addons.manager	WARN	Application shipped blocklist has an unexpected namespace (http://www.mozilla.org/newlayout/xml/parsererror.xml)
browser-helper: Something went wrong while trying to start browser-helper: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm -> file:///home/nicholascamp/projetos/gaia/profile-debug/extensions/[e-mail]/bootstrap.js :: startup :: line 134"  data: no]
2147942487JavaScript error: app://system.gaiamobile.org/shared/js/dump.js, line 24: settings is null
JavaScript error: app://system.gaiamobile.org/js/applications.js, line 85: apps.mgmt is undefined
JavaScript error: app://system.gaiamobile.org/shared/js/date_time_helper.js, line 33: window.navigator.mozSettings is null
JavaScript error: app://system.gaiamobile.org/shared/js/idletimer.js, line 101: navigator.addIdleObserver is not a function
JavaScript error: app://system.gaiamobile.org/shared/js/settings_listener.js, line 28: settings is null
JavaScript error: app://system.gaiamobile.org/shared/js/settings_listener.js, line 28: settings is null
JavaScript error: app://system.gaiamobile.org/js/icc.js, line 112: window.navigator.mozSettings is null
JavaScript error: app://system.gaiamobile.org/js/airplane_mode.js, line 17: window.navigator.mozSettings is null
JavaScript error: app://system.gaiamobile.org/js/cell_broadcast_system.js, line 15: settings is null
JavaScript error: app://system.gaiamobile.org/js/operator_variant/operator_variant_iccs.js, line 73: _settings is null
JavaScript error: app://system.gaiamobile.org/shared/js/settings_listener.js, line 28: settings is null
LogShake: starting captureLogs listener
JavaScript error: app://system.gaiamobile.org/js/call_forwarding.js, line 207: CallForwarding is not defined
JavaScript error: app://system.gaiamobile.org/js/findmydevice_launcher.js, line 32: navigator.mozSettings is null
JavaScript error: app://system.gaiamobile.org/js/newsletter_manager.js, line 103: navigator.addIdleObserver is not a function
JavaScript error: app://system.gaiamobile.org/shared/js/settings_listener.js, line 28: settings is null
JavaScript error: app://system.gaiamobile.org/js/internet_sharing.js, line 69: settings is null
JavaScript error: app://callscreen.gaiamobile.org/shared/js/date_time_helper.js, line 33: window.navigator.mozSettings is null
JavaScript error: app://callscreen.gaiamobile.org/js/call_screen.js, line 245: Argument 1 is not valid for any of the 2-argument overloads of URL.createObjectURL.

Comment 3

[Kevin Grandon :kgrandon]

I will look into this soon.

Comment 4

[Benoit Girard (:BenWa)]

We're hitting this after the first reboot. /edit-pref.sh seems to reproduce it well.

Comment 5

[Benoit Girard (:BenWa)]

Actually I see this on a real device with a tip/head/master build.

Comment 6

[Kevin Grandon :kgrandon]

It appears that SettingsChangeNotifier.jsm missing is the cause of this. Kyle - since you were in settings recently, do you know the changeset that removed this by chance? Is there another jsm we need to include now?

Comment 7

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Yup, yet another place I forgot to update the include. SettingsChangeNotifier is gone, I would /think/ we can just remove the include altogether since we bring SettingsRequestManager in with the b2g shell, but I'll test it and see.

Comment 8

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Fixing title. All reports here mention firefox desktop, not b2g desktop. Therefore comment 7 is wrong, we will need to include SettingsRequestManager here.

Comment 9

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - Fix settings includes in browser shims

Comment 10

[Kevin Grandon :kgrandon]

Comment on attachment 8485325 [details] [review]
Patch 1 (v1) - Fix settings includes in browser shims

Thanks Kyle!

Comment 11

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

[Blocking Requested - why for this release]: Breaks gaia development on Firefox Desktop, which is commonly used.

Comment 12

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

https://github.com/mozilla-b2g/gaia/commit/cb08eea42f13ca5b1b3fcc9f0b35f01370eab0b7

Comment 13

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8485325 [details] [review]
Patch 1 (v1) - Fix settings includes in browser shims

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 900551
[User impact] if declined: Can't develop for gaia on firefox desktop
[Testing completed]: Ran locally against firefox desktop, assured it works now
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]: None

Comment 14

[Nicholas Camp Barcellos]

Working now here. Kevin, Kyle, thanks!

Comment 15

[Kevin Grandon :kgrandon]

Uplifting to 2.1, a=npotb.

https://github.com/mozilla-b2g/gaia/commit/b9e593bb0d615a51348fc6c879ea196d705690af