Closed
Bug 1036787
Opened 10 years ago
Closed 9 years ago
[GAIA][Contacts]"SIM Card" Text in Contacts > Settings > Import Contants is not reflecting on language change
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Firefox OS Graveyard
Gaia::Contacts
Tracking
(Not tracked)
VERIFIED
WORKSFORME
People
(Reporter: ashayb2g, Assigned: ashayb2g, Mentored, NeedInfo)
Details
(Whiteboard: [LibGLA,TD71426,WW, B] [good first bug])
Attachments
(2 files, 2 obsolete files)
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:33.0) Gecko/20100101 Firefox/33.0 (Beta/Release) Build ID: 20140702030201 Steps to reproduce: 1] Phone > Contacts > Settings > Import Contants > "SIM Card" check wording 2] Home Key > Settings > Laguage - Japanese 3] 1] is repeated Actual results: "SIM Card" text remained in English only. Expected results: "SIM Card" text should be translated to language selected(Japanese in this case)
Summary: "SIM Card" Text in Contacts > Settings > Import Contants is not reflecting on language change → [GAIA][Contacts]"SIM Card" Text in Contacts > Settings > Import Contants is not reflecting on language change
Updated•10 years ago
|
Mentor: francisco
Whiteboard: [LibGLA,TD71426,WW, B] → [LibGLA,TD71426,WW, B] [good first bug]
Hi Francisco, Please review the PR. Thanks
Attachment #8455230 -
Flags: review?(francisco)
Comment 2•10 years ago
|
||
Comment on attachment 8455230 [details]
Pointer to Pull Request.html
Hi Ashay!
Great patch, we are close to the solution here.
I left some comments on github, also, could you add unit tests to the patch?
Thanks for your contribution!
Attachment #8455230 -
Flags: review?(francisco) → review-
Whiteboard: [LibGLA,TD71426,WW, B] [good first bug] → [LibGLA,TD71426,QE1, B] [good first bug]
Whiteboard: [LibGLA,TD71426,QE1, B] [good first bug] → [LibGLA,TD71426,WW, B] [good first bug]
Hi Francisco, Please review the the Updated PR with suggested changes and Unit test cases. Thanks
Attachment #8455230 -
Attachment is obsolete: true
Attachment #8460087 -
Flags: review?(francisco)
Comment 4•10 years ago
|
||
Comment on attachment 8460087 [details]
Pointer to Pull Request.html
Great job Ashay!
I'm forwarding the review to Michal, so we speedup the process.
Attachment #8460087 -
Flags: review?(francisco) → review?(mbudzynski)
Comment 5•10 years ago
|
||
Comment on attachment 8460087 [details]
Pointer to Pull Request.html
Hey, I put my remarks on Github, please respond to them (either fix or explain why you prefer doing it the way you did) and ask for R again. Thanks, great job so far!
Attachment #8460087 -
Flags: review?(mbudzynski)
Flags: needinfo?(ashayb2g)
Updated•10 years ago
|
Assignee: nobody → ashayb2g
Hi, PFA PR. Please review it and let me know your feedback. Regards Ashay
Attachment #8460087 -
Attachment is obsolete: true
Attachment #8466996 -
Flags: review?(mbudzynski)
Flags: needinfo?(ashayb2g)
Comment 7•10 years ago
|
||
Comment on attachment 8466996 [details]
Pointer to Pull Request.html
Great!
Just some small nits on Github, code looks good. Please squash commits before landing.
Attachment #8466996 -
Flags: review?(mbudzynski) → review+
Hi Michal, I have squashed commits as you said. Regarding landing, I don't have permission to land the code. So please do it. Thanks Ashay
Comment 9•10 years ago
|
||
There are still 2 Commits in the PR, please squash them together.
Comment 11•9 years ago
|
||
Hi Ashay, you still interested in fixing this bug? Unfortunately Michal is not working at mozilla anymore if you want to continue working on this, just move the review to myself. Thanks.
Flags: needinfo?(ashayb2g)
Assignee | ||
Comment 12•9 years ago
|
||
I think this issue is already fixed in 2.2. So would you please move it to Resolved.
Flags: needinfo?(ashayb2g)
Comment 13•9 years ago
|
||
Verifyme in 2.2 and master. If it works, please marks this bug as VERIFIED -> WORKSFORME.
Comment 14•9 years ago
|
||
Hi Reporter, I have uploaded the screenshot of the "SIM Card" view, the text under "SIM Card" is translated to language selected(Japanese in this case), could you help to verify whether this issue is fixed or not? If it has been fixed successfully, please marks this bug as VERIFIED -> WORKSFORME. Thanks! See attachment:screenshot.png Flame 2.2 build: Build ID 20150225002505 Gaia Revision ca64f2fe145909f31af266b1730874051ba76c78 Gaia Date 2015-02-24 22:06:53 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/16804008c29f Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150225.041814 Firmware Date Wed Feb 25 04:18:25 EST 2015 Bootloader L1TC000118D0 Flame 3.0 build: Build ID 20150225010244 Gaia Revision f6bfd854fe4746f21bc006eac145365e85f98808 Gaia Date 2015-02-24 21:10:44 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/0a8b3b67715a Gecko Version 39.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150225.043702 Firmware Date Wed Feb 25 04:37:14 EST 2015 Bootloader L1TC00011880
Flags: needinfo?(ashayb2g)
Assignee | ||
Comment 15•9 years ago
|
||
Hi, I don't have permission to Mark it as VERIFIED -> WORKSFORME, I can only assign it to some one or Mark as Resolved. Thanks Ashay
Flags: needinfo?(ashayb2g)
Comment 16•9 years ago
|
||
(In reply to ashayb2g from comment #15) > Hi, > > I don't have permission to Mark it as VERIFIED -> WORKSFORME, I can only > assign it to some one or Mark as Resolved. > > Thanks > Ashay Hi, Could you help to check the screenshot per comment 14 and help to make sure whether this issue is fixed or not? Thanks!
Assignee | ||
Comment 17•9 years ago
|
||
The screen shot looks fine and I have already verified it in 2.2, it works fine. Thanks!
Comment 18•9 years ago
|
||
(In reply to ashayb2g from comment #17) > The screen shot looks fine and I have already verified it in 2.2, it works > fine. > > Thanks! Thanks!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•