Closed Bug 1036812 Opened 11 years ago Closed 7 years ago

Confusing stacks reported when the stack-munging in Task.jsm throws an exception

Categories

(Toolkit :: Async Tooling, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: bzbarsky, Unassigned)

References

Details

See https://tbpl.mozilla.org/php/getParsedLog.php?id=43495901&tree=Try&full=1 What happened there, I think, is that this line in Task.jsm: 422 aException.stack = stack; threw the "TypeError: setting a property that has only a getter" bit, which propagated up to a previous catch from this same code. This then called _handleException with the TypeError in question, which helpfully stripped out the Task.jsm frames (which were where the exception actually happened) from the stack. Would it make sense to only break out of the loop in generateReadableStack once we've seen at least one non-Task.jsm frame? That way an exception in Task.jsm itself will get reported properly.
See Also: → 1126335
Per bug 1515695, we're moving away from Task.jsm, hence wontfix.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.