1036845 - [search] app text labels/titles don't wrap/linebreak

Status: RESOLVED DUPLICATE of bug 1026159

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

B2G 2.0.0.0-prerelease 20140708201453 on Geeksphone Keon

The text label of apps on the homescreen currently don't wrap on two lines if the label is too long for one line. This worked before. Regression from vertical homescreen?

This is especially an issue for collections, apps from the marketplace and bookmarks added to the homescreen.

Comment 1

[Johan Lorenzo [:jlorenzo]]

QA Wanted to check 1.4 Flame and 1.4 Buri.

Comment 2

[Jason Smith [:jsmith]]

(In reply to Johan Lorenzo [:jlorenzo] from comment #1)
> QA Wanted to check 1.4 Flame and 1.4 Buri.

We also need a screenshot of the bug here.

Comment 3

[Johan Lorenzo [:jlorenzo]]

Attachment: Long name comparison - Buri 1.3 - Buri 1.4 - Flame 1.4 - Flame 2.0

I tried with a smart collection called "my long name" and the app named "Info Whatsap and Firefox OS". I can't see any regression between 1.3/1.4 old homescreen and 2.0 vertical homescreen.

Archaeopteryx can you provide a screenshot of a label wrapped over 2 lines on the old homescreen?

Comment 4

[Jason Smith [:jsmith]]

This isn't a vertical homescreen bug.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Johan Lorenzo [:jlorenzo] from comment #3)
> Archaeopteryx can you provide a screenshot of a label wrapped over 2 lines
> on the old homescreen?
Sorry, the issue only applies to the search results of everything.me: 1-2 lines on 1.4 (20140710), 1 line on 20140708.

Comment 6

[Johan Lorenzo [:jlorenzo]]

Attachment: Search result comparison - Buri 1.4 - Flame 2.0

Comment 7

[Johan Lorenzo [:jlorenzo]]

Attachment: Search result comparison - Flame 1.4/2.0

Comment 8

[Johan Lorenzo [:jlorenzo]]

Would UX block on that regression?

Comment 9

[Cristian Rodriguez (:crdlc)]

I can confirm why it works so.. The gaia grid component is the same in vertical homescreen, collections and rocketbar suggestions. The behavior is the same in all UIs. The title's styles are the same in all places.

Comment 10

[Kevin Grandon :kgrandon]

So I guess we supported different wrapping in the old Everything.me code and the horizontal homescreen? +1 to what Cristian said. Ideally we don't have to have special cases and can use the same rendering logic everywhere, homescreen, collections, search. Though perhaps we should allow for a second line (but if so let's do so everywhere).

Comment 11

[Cristian Rodriguez (:crdlc)]

Yes, old home and ev.me had different code and rendering engine so they had different behavior

(In reply to Kevin Grandon :kgrandon from comment #10)
> So I guess we supported different wrapping in the old Everything.me code and
> the horizontal homescreen? +1 to what Cristian said. Ideally we don't have
> to have special cases and can use the same rendering logic everywhere,
> homescreen, collections, search. Though perhaps we should allow for a second
> line (but if so let's do so everywhere).

Comment 12

[Stephany Wilkes]

UX would not block on this. And, good news in comment #9! :)

Comment 13

[robert.sajdok]

Attachment: Proposed fix.

Comment 14

[Kevin Grandon :kgrandon]

Comment on attachment 8457511 [details] [review]
Proposed fix.

Hey Robert,

Thanks for the patch! Generally some peer or owner of the code should review things, and myself or potentially daleharvey could review this.

I'm going to do a ni? on Peter as we do need visual specs for this. I don't think only changing the text wrapping is going to be quite polished visually.

I believe we had to agreed to compromise and only make the 4-column layout wrap.

Comment 15

[Kevin Grandon :kgrandon]

It looks like we have another bug and some specs in bug 1026159, and the patch there is further along. Let's go with that for now, but thanks so much for your contribution.