1036861 - [MTP] The file size is incorrect (0 bytes)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: MTP/UMS, defect)

Description

[Eric Chou [:ericchou] [:echou]]

The file size of every single file is always "0 bytes" when I view files on my Ubuntu 13.04 via MTP.

Comment 1

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: write file size into the response of getObjectInfo

In the response of operation GetObjectInfo, there is a field "ObjectCompressedSize". Currently it's assigned with 0. We need to put correct file size into it. I also corrected the type of property value in function getObjectPropertyDesc().

Comment 2

[Dave Hylands [:dhylands]]

Comment on attachment 8454307 [details] [diff] [review]
patch 1: v1: write file size into the response of getObjectInfo

Review of attachment 8454307 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: dom/system/gonk/MozMtpDatabase.cpp
@@ +634,5 @@
>    aInfo.mStorageID = entry->mStorageID;
>    aInfo.mFormat = entry->mObjectFormat;
>    aInfo.mProtectionStatus = 0x0;
> +
> +  if (entry->mObjectSize > 0xFFFFFFFFL) {

nit: since mObjectSize is uint64_t, I think that these constants should use uLL as the suffix.

i.e. 0xFFFFFFFFuLL to make the constant of a type consistant with uint64_t

Comment 3

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v2: write file size into the response of getObjectInfo, r=dhylands

* nit picked.

(This patch is based on the patch that Dave attached on bug 1029533. Waiting for bug 1029533 get resolved.)

Comment 4

[Eric Chou [:ericchou] [:echou]]

try: https://tbpl.mozilla.org/?tree=Try&rev=cde5b74b5d13

Comment 5

[Eric Chou [:ericchou] [:echou]]

b2g-inbound: https://hg.mozilla.org/integration/b2g-inbound/rev/9c1261190829

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9c1261190829