1036862 - [MTP] Unable to delete files

Status: RESOLVED FIXED

(Firefox OS Graveyard :: MTP/UMS, defect)

Description

[Eric Chou [:ericchou] [:echou]]

Host: Ubuntu 13.04

When I tried to delete files, an error message

   "libmtp error:  could not delete object."

showed.

Comment 1

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: Support 'Delete files/folders'

With this patch, users can delete files and folders on Firefox OS devices while using MTP. My host is Ubuntu 13.04.

Comment 2

[Dave Hylands [:dhylands]]

Comment on attachment 8459402 [details] [diff] [review]
patch 1: v1: Support 'Delete files/folders'

Review of attachment 8459402 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/MozMtpDatabase.cpp
@@ +793,2 @@
>  
> +  MTP_LOG("ready to delete file '%s'", entry->mPath.get());

nit: I'd change this to just be:

MTP_LOG("Handle: 0x%08x '%s'", aHandle, entry->mPath.get());

The MTP_LOG will print the function name to let us know we're deleting a file.

Comment 3

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: final: Support 'Delete files/folders', r=dhylands

* log message modified.

Thanks, Dave!

Comment 4

[Eric Chou [:ericchou] [:echou]]

b2g-inbound: https://hg.mozilla.org/integration/b2g-inbound/rev/6e1849b0b978

Comment 5

[Eric Chou [:ericchou] [:echou]]

Hi Ryan,

I found that this patch hasn't been merged into mozilla-central yet. Some other patches landed on b2g-inbound later than mine have been already in m-c. Would you mind taking a look for me?

Comment 6

[Ryan VanderMeulen [:RyanVM]]

It was merged yesterday. Looks like the bug got missed during marking.

https://hg.mozilla.org/mozilla-central/rev/6e1849b0b978

Note that hg csets are immutable, so in the case of merges, you can always change the URL to look for the hash on a different tree to confirm that it's there or not. (Not true for cherry-picked uplifts, though :)...)

Comment 7

[Eric Chou [:ericchou] [:echou]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #6)
> It was merged yesterday. Looks like the bug got missed during marking.
> 
> https://hg.mozilla.org/mozilla-central/rev/6e1849b0b978
> 
> Note that hg csets are immutable, so in the case of merges, you can always
> change the URL to look for the hash on a different tree to confirm that it's
> there or not. (Not true for cherry-picked uplifts, though :)...)

Ah, my bad. I should check m-c before asking for help. Thanks for quick response. :)