Closed Bug 1036862 Opened 10 years ago Closed 10 years ago

[MTP] Unable to delete files

Categories

(Firefox OS Graveyard :: MTP/UMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(feature-b2g:2.1, b2g-v2.1 fixed)

RESOLVED FIXED
2.1 S1 (1aug)
feature-b2g 2.1
Tracking Status
b2g-v2.1 --- fixed

People

(Reporter: echou, Assigned: echou)

References

Details

(Whiteboard: [ft:devices])

Attachments

(1 file, 1 obsolete file)

Host: Ubuntu 13.04

When I tried to delete files, an error message

   "libmtp error:  could not delete object."

showed.
Assignee: nobody → echou
Blocks: mtp
Depends on: 1029533
feature-b2g: --- → 2.1
With this patch, users can delete files and folders on Firefox OS devices while using MTP. My host is Ubuntu 13.04.
Attachment #8459402 - Flags: review?(dhylands)
Comment on attachment 8459402 [details] [diff] [review]
patch 1: v1: Support 'Delete files/folders'

Review of attachment 8459402 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/MozMtpDatabase.cpp
@@ +793,2 @@
>  
> +  MTP_LOG("ready to delete file '%s'", entry->mPath.get());

nit: I'd change this to just be:

MTP_LOG("Handle: 0x%08x '%s'", aHandle, entry->mPath.get());

The MTP_LOG will print the function name to let us know we're deleting a file.
Attachment #8459402 - Flags: review?(dhylands) → review+
* log message modified.

Thanks, Dave!
Attachment #8459402 - Attachment is obsolete: true
Hi Ryan,

I found that this patch hasn't been merged into mozilla-central yet. Some other patches landed on b2g-inbound later than mine have been already in m-c. Would you mind taking a look for me?
Flags: needinfo?(ryanvm)
It was merged yesterday. Looks like the bug got missed during marking.

https://hg.mozilla.org/mozilla-central/rev/6e1849b0b978

Note that hg csets are immutable, so in the case of merges, you can always change the URL to look for the hash on a different tree to confirm that it's there or not. (Not true for cherry-picked uplifts, though :)...)
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(ryanvm)
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S1 (1aug)
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #6)
> It was merged yesterday. Looks like the bug got missed during marking.
> 
> https://hg.mozilla.org/mozilla-central/rev/6e1849b0b978
> 
> Note that hg csets are immutable, so in the case of merges, you can always
> change the URL to look for the hash on a different tree to confirm that it's
> there or not. (Not true for cherry-picked uplifts, though :)...)

Ah, my bad. I should check m-c before asking for help. Thanks for quick response. :)
Whiteboard: [ft:devices]
Component: General → MTP/UMS
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: