1036921 - Have certain permissions be flagged for special attention

Status: VERIFIED FIXED

(Marketplace Graveyard :: Validation, defect, P1)

Description

[Andrew Williamson [:eviljeff]]

see https://bugzilla.mozilla.org/show_bug.cgi?id=1024396#c23 

" how about we modify the validator to put any apps using the special permissions in the escalation queue?  That would be an easy way to identify them, a relatively easy patch to write/maintain, and easy to back out when 2.1 lands.  I think for the low volume here (it sounds very likely no one will even try to use these other permissions) that is the easiest solution."

moz-attention
moz-firefox-accounts
moz-audio-channel-telephony
moz-audio-channel-ringer

Comment 1

[Wil Clouser [:clouserw]]

-> To Mark so this doesn't get lost.  Mark, let me know if there are any concerns.  Thanks.

Comment 2

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/zamboni/pull/2321
https://github.com/mozilla/app-validator/pull/33

Comment 3

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/app-validator/commit/e4fdcb90b79728bf5e78789f2496d81d6ed20500

Comment 4

[Mark Striemer [:mstriemer]]

The revertable commit for app-validator is https://github.com/mozilla/app-validator/commit/42ab4b0ea71fdd4707d0f384a2552ec8a2d62374.

Comment 5

[Mark Striemer [:mstriemer]]

The zamboni commit can be reverted https://github.com/mozilla/zamboni/commit/3695bed8db32869f2fe0704d4b3f713d90c8bc08.

Comment 6

[Mark Striemer [:mstriemer]]

Actually this is the commit: https://github.com/mozilla/zamboni/commit/e7a4ca3daf95e0639f4b179eb4f0e48c0e426b95.

Comment 7

[Mark Striemer [:mstriemer]]

Another zamboni commit to revert https://github.com/mozilla/zamboni/commit/7b5a7dfff619093e575ff8f1ca5d909459440115

Comment 8

[Mark Striemer [:mstriemer]]

If we revert this we should close bug 1040364.

Comment 9

[Andrew Williamson [:eviljeff]]

(In reply to Mark Striemer [:mstriemer] from comment #7)
> Another zamboni commit to revert
> https://github.com/mozilla/zamboni/commit/
> 7b5a7dfff619093e575ff8f1ca5d909459440115

? why would it be reverted?

Comment 10

[Mark Striemer [:mstriemer]]

I thought the idea was to remove support for this once 2.1 is release so I'm just keeping track of the commits for later.

Comment 11

[Andrew Williamson [:eviljeff]]

It'll have to be around for as long as we want apps to be supported on 2.0 (e.g. if an update to Loop is submitted that will work on 2.0 it will need to have those permissions allowed or the validator will reject them; but we can't blanket allow them because the APIs are never going to be stable enough for full access on 2.0)

Comment 12

[Madalin Cotetiu]

Please add STR here or mark it with [qa-] if no QA is needed.

Comment 13

[Mark Striemer [:mstriemer]]

Attachment: escalate.zip

1. Submit escalate.zip as a new Firefox OS app.
2. Verify that the app is not in the regular apps queue in the reviewer tools.
3. Verify that the app is in the escalation queue with a comment about it using prerelease permissions.

Comment 14

[Madalin Cotetiu]

App submission is currently blocked by Bug 1028908.

Comment 15

[Madalin Cotetiu]

Verified as fixed in marketplace-dev.allizom.org FF33 (Win7)
Postfix screencast: http://screencast.com/t/AzIihpeLw
Closing.