1036928 - Allow to set longer time estimages as 60 minutes

Status: RESOLVED WONTFIX

(Mozilla QA Graveyard :: One and Done, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We in the automation team want to add more tasks specifically for creating automated tests. Therefore we need a longer estimate of time, which can go up to a week. The 60s limit at the moment is a real blocker for us. Would be great if we can get this opened up.

Comment 1

[Rebecca Billings [:rbillings]]

The intention of One and Done as a tool was to provide a series of quick and easy tasks to new contributors- a way to sample QA tasks, and check out different teams. Having a task that takes longer than an hour defeats this purpose. That being said this would be better discussed in one of our meetings- please bring it up as an agenda item.

Comment 2

[Rebecca Billings [:rbillings]]

Discussed at today's meeting, adding to v2m2. Please add "60+" radio button to the Create task page. Add "60+" to the Estimated minutes checkboxes on Available Tasks and tasks/list.

Comment 3

[Bob Silverberg [:bsilverberg]]

One issue we will have with implementation for this is that the execution_time (estimated time to complete) is stored as an integer, so we cannot really have a value of 60+. One approach would be to choose an arbitrary number that is greater than 60 and then program the system to recognize that as 60+, but that's really a less-than-ideal approach.

A different approach would be significantly more complicated, though, so we need to consider that fact. Can you table this for discussion at our next meeting?

Comment 4

[Rebecca Billings [:rbillings]]

I've added it to the next meeting agenda as a discussion item. I can also see how it will impact task time estimates.

Comment 5

[Rebecca Billings [:rbillings]]

Instead of adding many radio buttons, let's make this a feature to add an empty box where admins creating a task can enter the time estimate.

Comment 6

[Rebecca Billings [:rbillings]]

This will require:
- on the create task page, add open text field next to time estimate radio buttons that only accepts whole numbers

Comment 7

[Bob Silverberg [:bsilverberg]]

Rebecca, I was proposing just replacing the existing select with a text box, so the only option will be to enter a number, not to add a text box in addition to the select. Does that sound ok to you?

Comment 8

[jicksy.john]

I would like to work on this. One question: We now have estimated time as 15,30,45,60. Do I need to add a new text area so that admin can give in their desired time limit or change the existing select with a text box like Bob suggested. 
If I change the existing select with text area- then we won't be having the dropdown of 15,30,45,60 right? Can I go ahead and work on this?

Comment 9

[Bob Silverberg [:bsilverberg]]

Thanks for offering to work on this Jicksy. Rebecca and I discussed this briefly and I think it would be better to go with her suggestion of adding a text input in addition to the select. That way most tasks will still end up with a standard increment which will work well with the filtering we have in place. So please go ahead and work on this (I will assign it to you) with the assumption that you will be adding a text input beside the existing select input.

Comment 10

[jicksy.john]

Bob,
We will be having choices (15,30,45,60,60+)
and also a text area where admin can enter any integer. Just confirming if what I made out is correct.

Comment 11

[Bob Silverberg [:bsilverberg]]

Thanks for checking Jicksy. No that is not correct. It will be choices of (15, 30, 45, 60) just like now, and also a text input where an admin can enter an integer.

Comment 12

[jicksy.john]

Bob,

I could get through the code.

I have certain doubts:
What I have done is- I created an integer field below 'estimated time' and named it 'customized time' (for now). If Admin wants to enter a time greater than 60, he can enter in this area.

If anytime Admin enters a value in this text field, then this value should over ride estimated_time- and while displaying task time it should show this manually entered time.

How will this be filtered in task filtering based on time? Should I make a clause 'Enter values more than 60 only' ?

So that in the filtering I can give a choice 60+ also, so that all those tasks that have more time than 60 will fall under that?
For a person searching for tasks with time more than 60 this should help.

Comment 13

[Bob Silverberg [:bsilverberg]]

Thanks for the update Jicksy. I'm not sure I fully understand what it is you have done. Could you submit a pull request so I can see the exact code? You can comment in the pull request that it is not yet complete and is only being submitted for feedback.

Comment 14

[jicksy.john]

https://github.com/mozilla/oneanddone/pull/208

Comment 15

[jicksy.john]

Ignore the previous pull request :
https://github.com/mozilla/oneanddone/pull/210

Comment 16

[jicksy.john]

This is the current running pull request. 
https://github.com/mozilla/oneanddone/pull/211

Comment 17

[Shubham Jindal [:shubham]]

https://github.com/mozilla/oneanddone/pull/236

Comment 18

[Rebecca Billings [:rbillings]]

This is available for contributors to work on.

Comment 19

[Rebecca Billings [:rbillings]]

Project is being retired.