1036979 - Add dennis to compile-mo.sh to prevent translation errors from killing an entire locale

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Localization, defect)

Description

[Luke Crouch [:groovecoder]]

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1036950#c1 ...

To prevent bugs like https://bugzilla.mozilla.org/show_bug.cgi?id=1036927, we should add dennis to our deployment workflow.

Here's zamboni's implementation:

https://github.com/mozilla/zamboni/blob/b142caf0b289a0eac8d9eeab470d6c67812c548e/locale/compile-mo.sh

Comment 1

[Luke Crouch [:groovecoder]]

Note: We should file a bug with Verbatim to prevent errors going into SVN.

Comment 2

[John Karahalis [:openjck]]

Related to (maybe a duplicate of) bug 812199

Comment 4

[Rob Hudson [:robhudson]]

Now that locales are part of our git repo I'm hoping to add a Travis-CI check so we can catch errors in our .po files. Even if it is after-the-fact, Travis will alert us of these errors and we can fix them ASAP.

We can also add a check during compile phase. I.e. if errors, skip compiling and report.

Comment 5

[Rob Hudson [:robhudson]]

Dennis linting was added to Travis-CI:
https://github.com/mozilla/kuma/commit/087eaef3d412c139fedf31be5b159269a17d82b4

Comment 6

[Rob Hudson [:robhudson]]

Resolving as fixed.