Remove cui-areatype from removable="false" widgets

RESOLVED FIXED in Firefox 33

Status

()

Firefox
Toolbars and Customization
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: Gijs, Assigned: dao)

Tracking

Trunk
Firefox 33
Points:
2
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Per bug 1014313 comment 36.


Array.map(document.querySelectorAll(":not([removable='true'])[cui-areatype]"), (n) => n.id).join(',')

on current fx-team, at least, produces the following list of elements:

menubar-items
tabbrowser-tabs
urlbar-container
back-button
forward-button
webrtc-status-button
nav-bar-overflow-button
PanelUI-button
PanelUI-menu-button
restore-button

I don't know how many of these can be removed outright and how many will need messing about with CSS before we can do that (or whether that means we should even do it).
(Assignee)

Comment 1

4 years ago
(In reply to :Gijs Kruitbosch from comment #0)
> I don't know how many of these can be removed outright and how many will
> need messing about with CSS before we can do that (or whether that means we
> should even do it).

I looked through <http://mxr.mozilla.org/mozilla-central/search?string=cui-areatype&find=\.css>. I don't think there's any dependency.
Assignee: nobody → dao
Component: General → Toolbars and Customization
(Assignee)

Comment 2

4 years ago
Created attachment 8456537 [details] [diff] [review]
patch

I also removed cui-areatype from updateCombinedWidgetStyle since (1) it's unused and (2) I think it's better to be consistent and only ever set the attribute on the actual customizable widget, rather than expecting extra code to be written for complex widgets in order to set the attribute on some of the nested nodes.
Attachment #8456537 - Flags: review?(gijskruitbosch+bugs)
(Reporter)

Updated

3 years ago
Attachment #8456537 - Flags: review?(gijskruitbosch+bugs) → review+
(Assignee)

Updated

3 years ago
Iteration: --- → 33.3
Points: --- → 2
QA Whiteboard: [qa-]
Flags: firefox-backlog+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/dcad44d79eee
Summary: Investigate removing instances of cui-areatype from removable="false" widgets → Remove cui-areatype from removable="false" widgets
https://hg.mozilla.org/mozilla-central/rev/dcad44d79eee
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Depends on: 1040810
You need to log in before you can comment on or make changes to this bug.