Closed
Bug 1037054
Opened 10 years ago
Closed 10 years ago
FxOS Loop client app bits for bug 1016277
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jaoo, Assigned: jaoo)
References
Details
Attachments
(1 file)
Lets add here the changes we need in the FxOS client app for handling gracefully the interruptions of GSM/CDMA calls during the Loop call.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8453916 -
Flags: review?(borja.bugzilla)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8453916 -
Flags: review?(borja.bugzilla) → review?(ferjmoreno)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8453916 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/36
Looks good! But I'd like to see a final version. It seems that you need to review the listeners stuff and the clean up or reuse story for the AudioContext and silence buffer.
Attachment #8453916 -
Flags: review?(ferjmoreno) → feedback+
|
||
Updated•10 years ago
|
|
|
||
Updated•10 years ago
|
Attachment #8453916 -
Flags: review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Thanks Fernando. Landed at:
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/a63d9bb8e5cc675f94a5286edfaedf990846d96d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•