1037081 - Tree row is no longer sortable in content preferences sub dialog

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Alice0775 White]

Steps To Reproduce:
1. Open in-content preferences
2. Open any sub dialog such as [Password manager], [Exceptions dialog]

Actual Results:
In content preferences sub dialog, Tree row is no longer sortable.

Expected Results:
Tree row should be sortable.

Comment 1

[u428464]

In fact it seems it's still sortable but only with right click.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: treecol.patch

Override http://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/incontentprefs/preferences.css#19

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8454926 [details] [diff] [review]
treecol.patch

Review of attachment 8454926 [details] [diff] [review]:
-----------------------------------------------------------------

I can't say I'm a fan of the "*" and wonder if there are going to be other behaviours that are broken because of the -moz-user-select.

::: browser/themes/shared/incontentprefs/preferences.css
@@ +754,5 @@
>    }
>  }
>  
> +treecol {
> +  -moz-user-select: none;

r=me if you move this new block directly below the "*" block:
* {
  -moz-user-select: text;
}

and add a comment under treecol explaining that this is so columns are sortable.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: patch for check-in

Addressed the comment

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c274ab1b4086

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c274ab1b4086

Comment 7

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified on Windows 7 32bit and Windows 7 64bit using latest Nightly 33.0a1 (buildID: 20140715030207) and the following mention should be done: 
- under Security tab -> "Saved Passwords" sub dialog -> if I perform right click on any sort preferences (e.g: site, username), the Context Menu (with "Copy Username", "Copy Password" options) is displayed, but the rows are also sorted -> It is ok? Is this behaviour intented?

Comment 8

[Richard Marti (:Paenglab)]

This happens also in normal dialog preferences (and also in TB). I would say this isn't intended but not caused by this bug.

Best is if you file a bug.

Comment 9

[Camelia Badau [:cbadau], Desktop Test Engineering]

I filled bug 1039540 .