1037103 - Remove ScopedDeleteArray from Scoped.h

Status: RESOLVED FIXED

(Core :: MFBT, task, P3)

Description

[Jeff Walden [:Waldo]]

Once people have switched to UniquePtr.h, we should remove this file.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Remove ScopedDeleteArray from Scoped.h

Patch awaits review of the current patches in bug 1037100, of course.  But no harm posting in advance of that.

Comment 2

[Jeff Walden [:Waldo]]

Attachment: Add deprecation notice/comments to Scoped.h

In advance of complete removal, at least we can clearly mark it as deprecated in the comments.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4f8848a15d76

Comment 4

[Jeff Walden [:Waldo]]

ScopedDeleteArray is removed (with a comment pointing searches to UniquePtr<T[]>).

https://hg.mozilla.org/integration/mozilla-inbound/rev/e2044e4fd875

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e2044e4fd875

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:Waldo, maybe it's time to close this bug?

Comment 7

[Jeff Walden [:Waldo]]

No, this is still valid.  Just not a huge priority.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:froydnj, maybe it's time to close this bug?

Comment 9

[Nathan Froyd [:froydnj]]

(In reply to Release mgmt bot [:sylvestre / :calixte] from comment #8)

The leave-open keyword is there and there is no activity for 6 months.
:froydnj, maybe it's time to close this bug?

Comment 7 says it all.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:Waldo, maybe it's time to close this bug?

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:Waldo, maybe it's time to close this bug?

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:sg, maybe it's time to close this bug?

Comment 13

[Simon Giesecke [:sg] [he/him]]

The bug still makes sense.

The following uses of symbols from Scoped.h are remaining right now:

• 2 uses of SCOPED_TEMPLATE
• 6 uses of MOZ_TYPE_SPECIFIC_SCOPED_POINTER_TEMPLATE
• 20 uses of Scoped, but some of those being typedefs with further uses

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:glandium, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 16

[Sylvestre Ledru [:Sylvestre]]

gcp, do you think we should finish this ?

Comment 17

[Gian-Carlo Pascutto [:gcp]]

Yeah, why not, just not a huge priority. "Good third bug".

Comment 18

[Kelsey Gilbert [:jgilbert]]

I did this as part of bug 1037100.

Comment 19

[Mathew Hodson]

Renamed to what actually landed in this bug in Firefox 34. I cannot set the milestone because it has been deactivated.