1037151 - Merge SharedSurface_GL with SharedSurface

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Kelsey Gilbert [:jgilbert]]

I believe these two classes have no compelling future where they're useful to keep separate.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: shsurf-always-gl

It's a big diff, but very sparse. It's mostly mechanical updates of s/gfx::/gl::/.

Comment 2

[Kelsey Gilbert [:jgilbert]]

This was written on top of the patch in bug 1037147.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: shsurf-always-gl

No longer depends on the other bug.

Comment 4

[Kelsey Gilbert [:jgilbert]]

It builds locally. Let's see what Try thinks.
https://tbpl.mozilla.org/?tree=Try&rev=d0bdec8d530c

(Mac LLVM warnings-as-errors in 3...2...1...)

Comment 5

[Kelsey Gilbert [:jgilbert]]

Oh cool, those are actual errors that were hidden behind ifdefs.

Comment 6

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8454071 [details] [diff] [review]
shsurf-always-gl

Review of attachment 8454071 [details] [diff] [review]:
-----------------------------------------------------------------

Concept is good, I trust you that all that changes are mechanical and haven't gone through all them individually.

Comment 7

[Kelsey Gilbert [:jgilbert]]

Attachment: shsurf-no-ws

r=mattwoodrow

Comment 8

[Kelsey Gilbert [:jgilbert]]

I found the logic piece I missed in the merge, so this should be better:
https://tbpl.mozilla.org/?tree=Try&rev=067eb96534e7

Comment 9

[Kelsey Gilbert [:jgilbert]]

Attachment: shsurf-always-gl

r=mattwoodrow

Comment 10

[Carsten Book [:Tomcat]]

seems there are bustages in the try run from comment #8 like https://tbpl.mozilla.org/php/getParsedLog.php?id=43571046&tree=Try is this fixed too ?

Comment 11

[Kelsey Gilbert [:jgilbert]]

(In reply to Carsten Book [:Tomcat] from comment #10)
> seems there are bustages in the try run from comment #8 like
> https://tbpl.mozilla.org/php/getParsedLog.php?id=43571046&tree=Try is this
> fixed too ?

There shouldn't be bustages from the one patch I checkin?'d. The other patch isn't ready to check in.

Comment 12

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f71f64ee925b

Comment 13

[Kelsey Gilbert [:jgilbert]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/855997734816

https://tbpl.mozilla.org/?tree=Try&rev=067eb96534e7
https://tbpl.mozilla.org/?tree=Try&rev=c7c82b1111e5
https://tbpl.mozilla.org/?tree=Try&rev=045a165ee933

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f71f64ee925b
https://hg.mozilla.org/mozilla-central/rev/855997734816