Closed Bug 1037164 Opened 6 years ago Closed 6 years ago

Preferences::SetFloat has a declaration but no definition

Categories

(Core :: Preferences: Backend, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

Preferences::SetFloat was added to Preferences.h in bug 826586 but it doesn't appear to ever have had an actual implementation.
Comment on attachment 8454031 [details] [diff] [review]
Patch

r=me
Attachment #8454031 - Flags: review?(bzbarsky) → review+
There are no issues with one thread setting, one thread accessing and the one getting the value managing to get half old half new value?
The float is stored as a string because we don't have native float preferences. So there should be no problem here, assuming that string prefs work.
> There are no issues with one thread setting, one thread accessing

Preferences are main-thread-only.
https://hg.mozilla.org/mozilla-central/rev/76928ae5c155
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.