Closed
Bug 1037217
Opened 11 years ago
Closed 11 years ago
Listen for DOMLinkChanged as well as DOMLinkAdded to update favicons
Categories
(Firefox for Android Graveyard :: Favicon Handling, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 33
People
(Reporter: Gijs, Assigned: mfinkle)
References
Details
Attachments
(1 file)
|
4.44 KB,
patch
|
bnicholson
:
review+
Gijs
:
feedback+
|
Details | Diff | Splinter Review |
Hurray, it's another favicon bug! I've CC'd mfinkle just for this.
But no fears, it's just that I added another chrome-only event so that websites that dynamically update favicons in a way that already works in Chrome and IE also work in Firefox desktop. I guess Android's code that looks for DOMLinkAdded will need to be updated to also look for DOMLinkChanged, but I wouldn't know exactly how to do that, so I'm just leaving this here and hoping y'all know what to do. :-)
|
Assignee | |
Comment 1•11 years ago
|
||
Based on Gijs' patch, this should be enough for Fennec. Tested using http://gijsk.com/mozilla/testcases/icons.html
Before: Does not swap favicon
After: Swaps favicon
Assignee: nobody → mark.finkle
Attachment #8454242 -
Flags: review?(bnicholson)
Attachment #8454242 -
Flags: feedback?(gijskruitbosch+bugs)
|
||
Updated•11 years ago
|
Attachment #8454242 -
Flags: review?(bnicholson) → review+
|
Reporter | |
Updated•11 years ago
|
Attachment #8454242 -
Flags: feedback?(gijskruitbosch+bugs) → feedback+
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•