[Flame][Wifi] wps-timedout event doesn't match the enum ConnectionStatus defined in webidl

RESOLVED FIXED in 2.0 S6 (18july)

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vchang, Assigned: vchang)

Tracking

unspecified
2.0 S6 (18july)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [p=1])

Attachments

(1 attachment)

It causes below javascript error when failed to connect to the access point using WPS in Flame.

E/GeckoConsole(14477): [JavaScript Error: "Return value of MozWifiConnection.status 'wps-timedout' is not a valid value for enumeration ConnectionStatus."]
E/GeckoConsole(14477): [JavaScript Error: "NS_ERROR_UNEXPECTED: " {file: "app://system.gaiamobile.org/js/wifi.js" line: 221}]
Assignee: nobody → vchang
Posted patch Patch v1.0Splinter Review
Fixed the typo in webidl.
Attachment #8454201 - Flags: review?(chulee)
Whiteboard: [p=1]
Target Milestone: --- → 2.0 S6 (18july)
Comment on attachment 8454201 [details] [diff] [review]
Patch v1.0

Review of attachment 8454201 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch!
But I think "wps-timeout" is correct, the typo is in DOMWifiManager.js[1].

[1] http://hg.mozilla.org/mozilla-central/file/e1a037c085d1/dom/wifi/DOMWifiManager.js#l363
Attachment #8454201 - Flags: review?(chulee) → review-
(In reply to Chuck Lee [:chucklee] from comment #2)
> Comment on attachment 8454201 [details] [diff] [review]
> Patch v1.0
> 
> Review of attachment 8454201 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Nice catch!
> But I think "wps-timeout" is correct, the typo is in DOMWifiManager.js[1].
> 
> [1]
> http://hg.mozilla.org/mozilla-central/file/e1a037c085d1/dom/wifi/
> DOMWifiManager.js#l363

So we should have a follow up bug for gaia?
Comment on attachment 8454201 [details] [diff] [review]
Patch v1.0

I also saw some variables using "timedout" in gecko, so I am not sure which one is preferred.
Modifying webidl seems to be less effort, but this needs to be reviewed by Blake.
Attachment #8454201 - Flags: review- → review?(mrbkap)
Attachment #8454201 - Flags: review?(mrbkap) → review+
https://hg.mozilla.org/mozilla-central/rev/5fb140442e18
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.