1037276 - [Flame][Wifi] wps-timedout event doesn't match the enum ConnectionStatus defined in webidl

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Vincent Chang[:vchang][changyihsin]]

It causes below javascript error when failed to connect to the access point using WPS in Flame.

E/GeckoConsole(14477): [JavaScript Error: "Return value of MozWifiConnection.status 'wps-timedout' is not a valid value for enumeration ConnectionStatus."]
E/GeckoConsole(14477): [JavaScript Error: "NS_ERROR_UNEXPECTED: " {file: "app://system.gaiamobile.org/js/wifi.js" line: 221}]

Comment 1

[Vincent Chang[:vchang][changyihsin]]

Attachment: Patch v1.0

Fixed the typo in webidl.

Comment 2

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Comment on attachment 8454201 [details] [diff] [review]
Patch v1.0

Review of attachment 8454201 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch!
But I think "wps-timeout" is correct, the typo is in DOMWifiManager.js[1].

[1] http://hg.mozilla.org/mozilla-central/file/e1a037c085d1/dom/wifi/DOMWifiManager.js#l363

Comment 3

[Vincent Chang[:vchang][changyihsin]]

(In reply to Chuck Lee [:chucklee] from comment #2)
> Comment on attachment 8454201 [details] [diff] [review]
> Patch v1.0
> 
> Review of attachment 8454201 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Nice catch!
> But I think "wps-timeout" is correct, the typo is in DOMWifiManager.js[1].
> 
> [1]
> http://hg.mozilla.org/mozilla-central/file/e1a037c085d1/dom/wifi/
> DOMWifiManager.js#l363

So we should have a follow up bug for gaia?

Comment 4

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Comment on attachment 8454201 [details] [diff] [review]
Patch v1.0

I also saw some variables using "timedout" in gecko, so I am not sure which one is preferred.
Modifying webidl seems to be less effort, but this needs to be reviewed by Blake.

Comment 5

[Vincent Chang[:vchang][changyihsin]]

https://hg.mozilla.org/integration/b2g-inbound/rev/5fb140442e18

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5fb140442e18