Assertion failure: JSID_IS_STRING(id) || JSID_IS_INT(id), at jswatchpoint.cpp with Symbol

RESOLVED FIXED in mozilla34

Status

()

Core
JavaScript Engine
--
critical
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gkw, Assigned: jorendorff)

Tracking

(Blocks: 1 bug, {assertion, regression, testcase})

Trunk
mozilla34
x86_64
Mac OS X
assertion, regression, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [jsbugmon:update])

Attachments

(3 attachments)

(Reporter)

Description

4 years ago
Created attachment 8454246 [details]
stack

Object.prototype.watch.call(1, Symbol(), function() {})

asserts js debug shell on m-c changeset 06e9a27a6fcc without any CLI arguments at Assertion failure: JSID_IS_STRING(id) || JSID_IS_INT(id), at jswatchpoint.cpp

My configure flags are:

CC="clang -Qunused-arguments" CXX="clang++ -Qunused-arguments" AR=ar sh /Users/skywalker/trees/mozilla-central/js/src/configure --target=x86_64-apple-darwin12.5.0 --enable-debug --enable-optimize --enable-profiling --enable-gczeal --enable-debug-symbols --disable-tests --enable-more-deterministic --with-ccache --enable-threadsafe <other NSPR options>

=== Tinderbox Build Bisection Results by autoBisect ===

The "good" changeset has the timestamp "20140623115045" and the hash "611283da02bf".
The "bad" changeset has the timestamp "20140623122048" and the hash "cd2894ed2c76".

Likely regression window: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=611283da02bf&tochange=cd2894ed2c76

Jason, is bug 645416 a likely regressor?
Flags: needinfo?(jorendorff)
(Assignee)

Comment 1

4 years ago
It's definitely the regressor.
Assignee: nobody → jorendorff
Flags: needinfo?(jorendorff)
(Assignee)

Comment 2

4 years ago
Created attachment 8459097 [details] [diff] [review]
bug-1037313-symbol-watchpoint-v1.patch

Jeff, I'd like to sneak this in before the train departs, if possible. Bogus assertions; all the machinery underneath just compares jsids using ==, which works the same for symbols as for PropertyKeys and indexes.
Attachment #8459097 - Flags: review?(jwalden+bmo)
(Assignee)

Comment 3

4 years ago
Pressure's off for FF33; there are enough minor bugs that I'm going to push Symbols out a release (see bug 1041631).

Updated

4 years ago
Attachment #8459097 - Flags: review?(jwalden+bmo) → review+
Created attachment 8470834 [details]
[crash-signature] Machine-readable crash signature
https://hg.mozilla.org/mozilla-central/rev/a1d05feda793
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.