1037317 - Move GMPBufferType to be a property of GMPVideoFrameEncoded

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

It would be better for GMPVideoEncodedFrame to have a GMPBufferType property, rather than us having to pass around a (GMPVideoEncodedFrame, GMPBufferType) pair all the time.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8454254 [details] [diff] [review]
Patch

Review of attachment 8454254 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/gmp/GMPTypes.ipdlh
@@ +3,5 @@
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
> +using GMPBufferType from "gmp-video-codec.h";
> + 

ws

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Attachment: OpenH264 buffertype changes

OpenH264 changes to match - putting here until I figure out why reviewboard didn't work for me

Comment 4

[Ethan Hugg [:ehugg]]

(In reply to Randell Jesup [:jesup] from comment #3)
> Created attachment 8454440 [details] [diff] [review]
> OpenH264 buffertype changes
> 
> OpenH264 changes to match - putting here until I figure out why reviewboard
> didn't work for me


Don't worry about reviewboard.  I will add this to the diff in 1020760 and post on rbcommons assuming it still works.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a58ad2a9b061

Comment 6

[Ethan Hugg [:ehugg]]

Comment on attachment 8454440 [details] [diff] [review]
OpenH264 buffertype changes


Worked for me.  Posted to rbcommons here - https://rbcommons.com/s/OpenH264/r/670/

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a58ad2a9b061