Closed Bug 1037317 Opened 6 years ago Closed 6 years ago

Move GMPBufferType to be a property of GMPVideoFrameEncoded

Categories

(Core :: Audio/Video, defect)

29 Branch
x86_64
All
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

It would be better for GMPVideoEncodedFrame to have a GMPBufferType property, rather than us having to pass around a (GMPVideoEncodedFrame, GMPBufferType) pair all the time.
Attached patch PatchSplinter Review
Attachment #8454254 - Flags: review?(rjesup)
Comment on attachment 8454254 [details] [diff] [review]
Patch

Review of attachment 8454254 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/gmp/GMPTypes.ipdlh
@@ +3,5 @@
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
> +using GMPBufferType from "gmp-video-codec.h";
> + 

ws
Attachment #8454254 - Flags: review?(rjesup) → review+
OpenH264 changes to match - putting here until I figure out why reviewboard didn't work for me
Attachment #8454440 - Flags: review?(ethanhugg)
(In reply to Randell Jesup [:jesup] from comment #3)
> Created attachment 8454440 [details] [diff] [review]
> OpenH264 buffertype changes
> 
> OpenH264 changes to match - putting here until I figure out why reviewboard
> didn't work for me


Don't worry about reviewboard.  I will add this to the diff in 1020760 and post on rbcommons assuming it still works.
Comment on attachment 8454440 [details] [diff] [review]
OpenH264 buffertype changes


Worked for me.  Posted to rbcommons here - https://rbcommons.com/s/OpenH264/r/670/
Attachment #8454440 - Flags: review?(ethanhugg) → review+
https://hg.mozilla.org/mozilla-central/rev/a58ad2a9b061
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.