Remove the obsolete references to the TelephonyCall.number and TelephonyCall.secondNumber fields

RESOLVED FIXED in 2.1 S6 (10oct)

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gsvelto, Assigned: drs)

Tracking

unspecified
2.1 S6 (10oct)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(b2g-v2.2 fixed)

Details

(Whiteboard: [planned-sprint c=1])

Attachments

(1 attachment, 4 obsolete attachments)

+++ This bug was initially created as a clone of Bug #1005766 +++

Bug 981519 replaced TelephonyCall.number and TelephonyCall.secondNumber with TelephonyCall.id and TelephonyCall.secondId. In bug 1005766 we landed some compatibility glue in Gaia to ensure the callscreen would work with both. Now that the Gecko change has stuck it's time to remove the use of the obsolete fields from Gaia.
Summary: Remove the references to the TelephonyCall.number → Remove the obsolete references to the TelephonyCall.number and TelephonyCall.secondNumber fields
Whiteboard: [planned-sprint]
Target Milestone: --- → 2.1 S6 (10oct)
Assignee: nobody → drs+bugzilla
Whiteboard: [planned-sprint] → [planned-sprint c=1]
PR: https://github.com/mozilla-b2g/gaia/pull/24541

Etienne, feel free to redirect the dialer component to Gabriele. I thought it would make more sense for you to just review the whole thing since this is such a small and clear change.
Attachment #8497298 - Flags: review?(etienne)
Comment on attachment 8497298 [details] [diff] [review]
Remove the obsolete references to the TelephonyCall.number and TelephonyCall.secondNumber fields.

Review of attachment 8497298 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the remaining |secondNumber| references in |dialer.js| (and |dialer_test.js|) fixed (cdma stuff, might have been broken for a while...)
Attachment #8497298 - Flags: review?(etienne) → review+
Yikes, good catch. I didn't think that was referring to a TelephonyCall object. Carrying r+.
Attachment #8497298 - Attachment is obsolete: true
Attachment #8497647 - Flags: review+
https://github.com/mozilla-b2g/gaia/commit/0e280591881d44b80f456bc27e12d9114c218868
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
(In reply to Etienne Segonzac (:etienne) from comment #2)
> Comment on attachment 8497298 [details] [diff] [review]
> Remove the obsolete references to the TelephonyCall.number and
> TelephonyCall.secondNumber fields.
> 
> Review of attachment 8497298 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me with the remaining |secondNumber| references in |dialer.js| (and
> |dialer_test.js|) fixed (cdma stuff, might have been broken for a while...)

Thanks for being thorough on this. Unfortunately, I should have tested this, as it was wrong, and it is actually a different object. Here's a followup to back out that portion of the changes.

PR: https://github.com/mozilla-b2g/gaia/pull/24579
Attachment #8497681 - Flags: review?(thills)
Attachment #8497681 - Flags: review?(thills)
Attachment #8497681 - Attachment is obsolete: true
Attachment #8497696 - Flags: review?(gsvelto)
Backed out of master: https://github.com/mozilla-b2g/gaia/commit/023674ab6fe8daa74fb623cda5274e396146ec47
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
PR: https://github.com/mozilla-b2g/gaia/pull/24589

Sorry about the trainwreck here. This is a rollup of the original fix and the followup. I did manual testing this time.
Attachment #8497647 - Attachment is obsolete: true
Attachment #8497696 - Attachment is obsolete: true
Attachment #8497696 - Flags: review?(gsvelto)
Attachment #8497914 - Flags: review?(etienne)
Comment on attachment 8497914 [details] [diff] [review]
Remove the obsolete references to the TelephonyCall.number and TelephonyCall.secondNumber fields.

Review of attachment 8497914 [details] [diff] [review]:
-----------------------------------------------------------------

triple-checked
Attachment #8497914 - Flags: review?(etienne) → review+
https://github.com/mozilla-b2g/gaia/commit/4083d159cc76502bd3318b8676801abb4ebef630
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.