Closed Bug 1037372 Opened 10 years ago Closed 10 years ago

Add speculativeConnect() method to search engines, SeaMonkey part.

Categories

(SeaMonkey :: Search, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.30

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

Attachments

(1 file)

(from Bug 1006103 comment #0)
> searchSpeculativeConnectAPI
> 
> We use nsISpeculativeConnect to speed up search suggestions/results in a
> couple of places (desktop searchbar and mobile search, the latter of which
> doesn't do the right thing if search and suggest URLs differ).  I'd like to
> use it in about:home in bug 612453, and eventually about:newtab (though that
> should be one shared bit of code).  At this point, it seems saner to just
> make this a method on the engine object.
> 
> Thus, here's a patch that does this.  If this is good, I'll replace the
> mobile caller with the API call as a part 2.

See: mozilla-central changeset 99b1e61cbb92
https://hg.mozilla.org/mozilla-central/rev/99b1e61cbb92
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #8454609 - Flags: review?(neil)
Comment on attachment 8454609 [details] [diff] [review]
Patch v1.0 fixit.

>+        this.currentEngine.speculativeConnect({window: window});
>         }
Spurious }. r=me with that fixed.
Attachment #8454609 - Flags: review?(neil) → review+
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/dcfc843590fc
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.30
You need to log in before you can comment on or make changes to this bug.