1037391 - Loop cannot be installed via make reset-gaia/install-gaia

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

Apparently, the custom origin is not being set properly

Comment 1

[Albert [:albert]]

Attachment: Patch

The patch checks if origin origin exists at build time when making webapps.

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Albert, why do we use https://marketplace.firefox.com for installOrigin if webapp.manifest.origin exists? and we should have a test for this fix, could you add into your pr?

BTW, what is loop app?

Comment 3

[Antonio Manuel Amaya Calvo (:amac)]

Comment on attachment 8457204 [details]
Patch

I left a comment on github. Other than that, it's working perfectly, thank you!

Comment 4

[Albert [:albert]]

(In reply to Yuren [:yurenju] from comment #2)
> Albert, why do we use https://marketplace.firefox.com for installOrigin if
> webapp.manifest.origin exists? and we should have a test for this fix, could
> you add into your pr?
> 
> BTW, what is loop app?

Removed hardcoded installOrigin, now use installOrigin from metadata if available or origin.

Added build integration test for custom origin.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8457204 [details]
Patch

also request feedback Fabrice since I don't know if we allow modifying origin/installOrigin from external app or not.

but code looks and thanks for your test, r=yurenju

please wait fabrice's feedback before landing.

Comment 6

[[:fabrice] Fabrice Desré]

Comment on attachment 8457204 [details]
Patch

Yep it's fine to do that.

Comment 7

[Albert [:albert]]

Master https://github.com/mozilla-b2g/gaia/commit/c7436f98cf958b5e5e9ab8d350d6980bab059157