Closed Bug 1037494 Opened 7 years ago Closed 7 years ago

Add author field to Histograms.json

Categories

(Toolkit :: Telemetry, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: rvitillo, Assigned: rvitillo)

References

Details

Attachments

(1 file, 4 obsolete files)

The author field is needed to allow Telemetry's alerting system to send an e-mail to the the interested party when an histogram changes.
Assignee: nobody → rvitillo
I'd suggest calling it "alert_emails"  or something like that and having it support multiple comma-separated email addresses
Please ensure that "histogram_tools.py" still parses the Histograms.json file after this change.
Attachment #8456867 - Flags: review?(vdjeric)
Attachment #8456867 - Attachment is obsolete: true
Attachment #8456904 - Flags: review?(vdjeric)
Unbitrotted.
Attachment #8456904 - Attachment is obsolete: true
Attachment #8456904 - Flags: review?(vdjeric)
Attachment #8459590 - Flags: review?(vdjeric)
Comment on attachment 8459590 [details]
Bug 1037494 - Add author field to Histograms.json, v3

I like the alert field's format, but I'm not sure making this change in bulk is the right approach. It's not always correct to tie the alerts to the developer's email address. For example, I added a bunch of LocalStorage histograms a long time ago but that feature has since been completely re-implemented by Necko team. Also if a dev leaves a company, we don't want the alerts getting ignored.

Let's start off with a discussion on the newsgroups about how people want to be notified. Then we can auto-generate emails to the histogram authors asking them to add the right notification addresses to the alert_emails field in Histograms.json, and also point these devs to the ServiceDesk link for creating new email aliases. We should implement and test the notification functionality before sending out this email request.
Attachment #8459590 - Flags: review?(vdjeric)
(In reply to Vladan Djeric (:vladan) from comment #6)
> Comment on attachment 8459590 [details]
> Bug 1037494 - Add author field to Histograms.json, v3
> 
> I like the alert field's format, but I'm not sure making this change in bulk
> is the right approach. It's not always correct to tie the alerts to the
> developer's email address. For example, I added a bunch of LocalStorage
> histograms a long time ago but that feature has since been completely
> re-implemented by Necko team. 
Right, my thought was that even if the developer that gets the alert is not right one, he probably knows who to get in touch with to correctly re-assign it.

> Also if a dev leaves a company, we don't want the alerts getting ignored.
Yes, in fact there are some developers that receive all alerts (like myself). 

> Let's start off with a discussion on the newsgroups about how people want to
> be notified. Then we can auto-generate emails to the histogram authors
> asking them to add the right notification addresses to the alert_emails
> field in Histograms.json, and also point these devs to the ServiceDesk link
> for creating new email aliases. We should implement and test the
> notification functionality before sending out this email request.

OK
Attachment #8459590 - Attachment is obsolete: true
Attachment #8463460 - Flags: review?(vdjeric)
Attachment #8463460 - Attachment is obsolete: true
Attachment #8463460 - Flags: review?(vdjeric)
Attachment #8463461 - Flags: review?(vdjeric)
Attachment #8463461 - Flags: review?(vdjeric) → review+
I'm assuming you've talked to Mark that this won't break anything server-side such as server-side parsing of Histograms.json
(In reply to Vladan Djeric (:vladan) from comment #10)
> I'm assuming you've talked to Mark that this won't break anything
> server-side such as server-side parsing of Histograms.json

Yep, we just need to make sure histogram_tools.py is able to handle Histograms.json versions with and without the new field. Then when this lands I'll update the server(s) with the latest histogram_tools.py from mercurial.
https://hg.mozilla.org/mozilla-central/rev/b39daaf8394b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.