Closed
Bug 1037516
Opened 10 years ago
Closed 10 years ago
2.1% osx 10.6 kraken regression on inbound (fx33) from push baec82f2baeb on July 8
Categories
(Core :: JavaScript: GC, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: jmaher, Assigned: jonco)
References
Details
(Keywords: perf, regression, Whiteboard: [talos_regression])
Attachments
(1 file)
717 bytes,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
Here is a graph to show the problem:
http://graphs.mozilla.org/graph.html#tests=[[232,63,21]]&sel=1404743285000,1404916085000
I did some retriggers to help show the failure:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&fromchange=e5c88681e091&tochange=b94c916122c8&jobname=Rev4%20MacOSX%20Snow%20Leopard%2010.6%20mozilla-inbound%20talos%20dromaeojs
we end up at this changeset:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c6ca2340a718&tochange=baec82f2baeb
The problem seems to be in audio-beat-detection:
http://people.mozilla.org/~klahnakoski/talos/Alert-Results.html#sampleMin=2014-07-07&platform=x86_64&sampleMax=2014-07-10&branch=Fx-Team&test=audio-beat-detection&os=mac.OS+X+10.6.8
this appears to be osx 10.6 only.
Assignee | ||
Comment 1•10 years ago
|
||
Removing bug 1034566 as that code isn't normally built.
No longer blocks: 1034566
Reporter | ||
Comment 2•10 years ago
|
||
so this is related to bug 988486 or more specifically:
https://hg.mozilla.org/integration/mozilla-inbound/rev/baec82f2baeb
Assignee | ||
Comment 3•10 years ago
|
||
Bug 988486 is just refactoring, and almost none of the code touched is hot.
The only thing I can think of is that as GCRuntime::updateBytesAllocated() is marked inline only in the class declaration and not in the definition then clang might not be inlining it and that might cause this regression.
Here's a patch to test this.
Attachment #8455271 -
Flags: review?(terrence)
Updated•10 years ago
|
Attachment #8455271 -
Flags: review?(terrence) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Keywords: leave-open
Reporter | ||
Comment 6•10 years ago
|
||
thanks, this regression appears to be fixed!
Assignee | ||
Comment 7•10 years ago
|
||
Great, let's close this.
Updated•10 years ago
|
Assignee: nobody → jcoppeard
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•