Closed Bug 1037516 Opened 5 years ago Closed 5 years ago

2.1% osx 10.6 kraken regression on inbound (fx33) from push baec82f2baeb on July 8

Categories

(Core :: JavaScript: GC, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: jmaher, Assigned: jonco)

References

Details

(Keywords: perf, regression, Whiteboard: [talos_regression])

Attachments

(1 file)

Removing bug 1034566 as that code isn't normally built.
No longer blocks: 1034566
Attached patch bug1037516-talosSplinter Review
Bug 988486 is just refactoring, and almost none of the code touched is hot.

The only thing I can think of is that as GCRuntime::updateBytesAllocated() is marked inline only in the class declaration and not in the definition then clang might not be inlining it and that might cause this regression.

Here's a patch to test this.
Attachment #8455271 - Flags: review?(terrence)
Attachment #8455271 - Flags: review?(terrence) → review+
thanks, this regression appears to be fixed!
Great, let's close this.
Status: NEW → RESOLVED
Closed: 5 years ago
Keywords: leave-open
Resolution: --- → FIXED
Assignee: nobody → jcoppeard
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.