Closed Bug 1037584 Opened 10 years ago Closed 7 years ago

Changes from #890556 breaks player unit test

Categories

(Webmaker Graveyard :: popcorn.js, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: gmarshall, Assigned: thecount)

Details

Attachments

(3 files)

The changes applied from #890556 breaks the unit tests in "modules/player/popcorn.player.unit.html".
Attached image IE9 with patch
Attached image IE9 without patch
The attached patch fixes the player code to pass the "Popcorn.smart - audio and video elements" unit test for all browsers. On the same note I had also removed the IE9 hackery because it seems to be a non-issue in version 9.0.8112.16421 (Final Release). All IE9 builds prior to this were preview builds and should not be considered supported versions. IE9 Wikipedia article for reference http://en.wikipedia.org/wiki/Internet_Explorer_9
Assignee: nobody → scott
Flags: needinfo?(scott)
We're deprecating the Webmaker Product on Bugzilla, so I'm marking this as resolved:incomplete

If this issue needs to be reopened, you can file it at https://github.com/mozilla/popcorn-js/issues/new
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
Flags: needinfo?(sdowne)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: