Changes from #890556 breaks player unit test

RESOLVED INCOMPLETE

Status

Webmaker
popcorn.js
RESOLVED INCOMPLETE
4 years ago
a year ago

People

(Reporter: George Marshall, Assigned: thecount, NeedInfo)

Tracking

Details

Attachments

(3 attachments)

(Reporter)

Description

4 years ago
The changes applied from #890556 breaks the unit tests in "modules/player/popcorn.player.unit.html".
(Reporter)

Comment 1

4 years ago
Created attachment 8455609 [details] [review]
Changes to default player
(Reporter)

Comment 2

4 years ago
Created attachment 8455611 [details]
IE9 with patch
(Reporter)

Comment 3

4 years ago
Created attachment 8455612 [details]
IE9 without patch
(Reporter)

Comment 4

4 years ago
The attached patch fixes the player code to pass the "Popcorn.smart - audio and video elements" unit test for all browsers. On the same note I had also removed the IE9 hackery because it seems to be a non-issue in version 9.0.8112.16421 (Final Release). All IE9 builds prior to this were preview builds and should not be considered supported versions. IE9 Wikipedia article for reference http://en.wikipedia.org/wiki/Internet_Explorer_9

Updated

4 years ago
Assignee: nobody → scott
Flags: needinfo?(scott)
We're deprecating the Webmaker Product on Bugzilla, so I'm marking this as resolved:incomplete

If this issue needs to be reopened, you can file it at https://github.com/mozilla/popcorn-js/issues/new
Status: UNCONFIRMED → RESOLVED
Last Resolved: a year ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.