Closed Bug 1037646 Opened 6 years ago Closed 6 years ago
Improve FM radio setup code
This patch fixes a few things: 1. It switches from storing frequencies in double to uint32_t. Internally, frequencies are always in whole kHz, so there's no point in using a large floating point type. 2. It eliminates the channel spacing defines. The defines didn't make the code any clearer. 3. Preemphasis is actually configured now. AIUI, preemphasis was a random undefined value before. Proper deemphasis configuration is necessary for FM radio to sound right.
Attachment #8454684 - Flags: review?(pzhang)
Attachment #8454684 - Flags: review?(pzhang) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.