Closed Bug 1037646 Opened 6 years ago Closed 6 years ago

Improve FM radio setup code

Categories

(Core :: DOM: Device Interfaces, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(1 file)

This patch fixes a few things:

1. It switches from storing frequencies in double to uint32_t. Internally, frequencies are always in whole kHz, so there's no point in using a large floating point type.
2. It eliminates the channel spacing defines. The defines didn't make the code any clearer.
3. Preemphasis is actually configured now. AIUI, preemphasis was a random undefined value before. Proper deemphasis configuration is necessary for FM radio to sound right.
Attachment #8454684 - Flags: review?(pzhang)
Blocks: 1036873
Attachment #8454684 - Flags: review?(pzhang) → review+
https://hg.mozilla.org/mozilla-central/rev/f5846689d910
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.