1037649 - Failed to remove file extensions\trash\[e-mail]: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]

Status: RESOLVED INVALID

(Firefox :: General, defect)

Description

[Gregory Szorc [:gps]]

Report from Catalin in Firefox 10 through 17.

Error: ERROR addons.xpi: Failed to remove file C:\Users\camelia.badau\AppData\Roaming\Mozilla\Firefox\Profiles\2bj5ep00.21\extensions\trash\[e-mail]: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource:///modules/XPIProvider.jsm :: recursiveRemove :: line 1256"  data: no]

Beside this error a Mozilla\Firefox\Profiles\1modinl0.9\extensions\trash\[e-mail] files remains undeleted in the Profile folder.
Please note that the update finishes with success and this issue doesn't affect the update.

---

My initial reaction is "meh, this is something weird in AddonManager land." But, I'd like to investigate first to make sure it really is benign.

Comment 1

[Gregory Szorc [:gps]]

I am unable to reproduce this.

Steps attempted:

1) Install Firefox 11 on Windows 7
2) Hack up prefs to use dev update server and enable update and extension logging
3) Restart
4) Opt in to Telemetry via toolbar
5) Trigger 3 manual update checks via privileged console
6) Accept UAC prompt after hotfix is downloaded
7) Restart
8) Open console and don't see this error

Comment 2

[Gregory Szorc [:gps]]

Perhaps Blair can shed some light on this trash directory, what might be happening, and whether it is worth digging into.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

This is safe, and in certain conditions is even expected due to file locks on Windows. The directory should be emptied the next time Firefox starts up. 

Context: The trash directory exists partly due to this type of problem, and partly so that we can do a rollback when something like an upgrade fails.