1037704 - Add polling support to SharedSurface

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Kelsey Gilbert [:jgilbert]]

Attachment: surf-poll

With bug 1023558 or similar, we're going to want to poll for FenceSync completion. Let's add support for that now.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8454734 [details] [diff] [review]
surf-poll

Review of attachment 8454734 [details] [diff] [review]:
-----------------------------------------------------------------

Let's try mattwoodrow.

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8454734 [details] [diff] [review]
surf-poll

Review of attachment 8454734 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/SharedSurfaceGL.cpp
@@ +415,5 @@
> +SharedSurface_GLTexture::PollSync()
> +{
> +    MutexAutoLock lock(mMutex);
> +    if (!mSync) {
> +        // Already sync'd!

I like the WaitSync comment for this condition ("We must have used glFinish instead of glFenceSync") better.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: surf-poll

r=mattwoodrow

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: surf-poll

r=mattwoodrow

Comment 5

[Kelsey Gilbert [:jgilbert]]

  https://hg.mozilla.org/integration/mozilla-inbound/rev/4df1d10a90cc

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4df1d10a90cc