Closed Bug 1037704 Opened 6 years ago Closed 6 years ago

Add polling support to SharedSurface

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

Attachments

(1 file, 2 obsolete files)

Attached patch surf-poll (obsolete) — Splinter Review
With bug 1023558 or similar, we're going to want to poll for FenceSync completion. Let's add support for that now.
Attachment #8454734 - Flags: review?(jmuizelaar)
Comment on attachment 8454734 [details] [diff] [review]
surf-poll

Review of attachment 8454734 [details] [diff] [review]:
-----------------------------------------------------------------

Let's try mattwoodrow.
Attachment #8454734 - Flags: review?(jmuizelaar) → review?(matt.woodrow)
Comment on attachment 8454734 [details] [diff] [review]
surf-poll

Review of attachment 8454734 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/SharedSurfaceGL.cpp
@@ +415,5 @@
> +SharedSurface_GLTexture::PollSync()
> +{
> +    MutexAutoLock lock(mMutex);
> +    if (!mSync) {
> +        // Already sync'd!

I like the WaitSync comment for this condition ("We must have used glFinish instead of glFenceSync") better.
Attachment #8454734 - Flags: review?(matt.woodrow) → review+
Attached patch surf-poll (obsolete) — Splinter Review
r=mattwoodrow
Attachment #8454734 - Attachment is obsolete: true
Attachment #8467267 - Flags: review+
Attached patch surf-pollSplinter Review
r=mattwoodrow
Attachment #8467267 - Attachment is obsolete: true
Attachment #8467270 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/4df1d10a90cc
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.