Closed
Bug 1037740
Opened 9 years ago
Closed 9 years ago
Private Tabs verbiage is truncated on small tablet
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox33 verified, firefox34 verified, fennec33+)
VERIFIED
FIXED
Firefox 34
People
(Reporter: rnewman, Assigned: mcomella)
References
Details
Attachments
(3 files)
137.44 KB,
image/png
|
Details | |
1.42 KB,
patch
|
wesj
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
73.54 KB,
image/png
|
antlam
:
feedback+
|
Details |
See attached screenshot.
Reporter | ||
Comment 1•9 years ago
|
||
Presumably these strings haven't been localized because they're recent…
Assignee | ||
Comment 2•9 years ago
|
||
Worth noting that we're doing some adjustments to the private tabs panel in bug 1021356, including adding a ScrollView so that the text can be panned, so we should tackle the spacing for this bug after that one.
Comment 3•9 years ago
|
||
This is in on Aurora now. Just saw this on trunk and found this bug. Tracking plz.
Comment 4•9 years ago
|
||
(Saw this on my Nexus 7, 2013 fwiw)
Comment 5•9 years ago
|
||
Is this still a problem? Do we want to tweak this design to improve readability? Tracking 33 to make a decision about this.
tracking-fennec: ? → 33+
Flags: needinfo?(michael.l.comella)
Flags: needinfo?(alam)
Reporter | ||
Comment 6•9 years ago
|
||
Still happens on fx-team.
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to :Margaret Leibovic from comment #5) > Do we want to tweak this design to improve readability? I don't believe I made small tablet specific styles for small tablet and it looks a bit goofy so I think it'd be worth making the change. I'll try to make it look more like phone and large tablet, unless Anthony has some additional feedback.
Flags: needinfo?(michael.l.comella)
Assignee | ||
Comment 8•9 years ago
|
||
Attachment #8465780 -
Flags: review?(bnicholson)
Assignee | ||
Comment 9•9 years ago
|
||
Attachment #8465784 -
Flags: feedback?(alam)
Assignee | ||
Comment 10•9 years ago
|
||
The screenshat from comment 9 is from the Kobo Arc.
Comment 11•9 years ago
|
||
Comment on attachment 8465784 [details]
After patch v1
I know we don't have a lot of space to work with here so I think this will do for now. Nicely done Michael!
Attachment #8465784 -
Flags: feedback?(alam) → feedback+
Flags: needinfo?(alam)
Assignee | ||
Comment 12•9 years ago
|
||
Comment on attachment 8465780 [details] [diff] [review] Update empty private tabs panel styles for small tablet bnicholson seems MIA.
Attachment #8465780 -
Flags: review?(bnicholson) → review?(wjohnston)
Comment 13•9 years ago
|
||
Comment on attachment 8465780 [details] [diff] [review] Update empty private tabs panel styles for small tablet Review of attachment 8465780 [details] [diff] [review]: ----------------------------------------------------------------- How does this look in portrait? i.e. Do we want this to be landscape specific?
Attachment #8465780 -
Flags: review?(wjohnston) → review+
Reporter | ||
Comment 14•9 years ago
|
||
Portrait is where I saw the problem, FWIW.
Assignee | ||
Comment 15•9 years ago
|
||
(In reply to Wesley Johnston (:wesj) from comment #13) > How does this look in portrait? i.e. Do we want this to be landscape > specific? I think you have portrait and landscape backwards, by the way. Landscape uses the small side bar and doesn't have this issue.
Assignee | ||
Comment 16•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/cd118a9e2d18
Assignee | ||
Comment 17•9 years ago
|
||
Comment on attachment 8465780 [details] [diff] [review] Update empty private tabs panel styles for small tablet Approval Request Comment [Feature/regressing bug #]: Private tabs panel description [User impact if declined]: Users will have an inconsistent experience where the look of the private tabs panel on small tablets changes between versions [Describe test coverage new/current, TBPL]: Tested locally [Risks and why]: Low, we just changed styles specific to small tablet. Worst case, we further break the panel on small tablet. [String/UUID change made/needed]: None
Attachment #8465780 -
Flags: approval-mozilla-aurora?
Comment 18•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cd118a9e2d18
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8465780 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 20•9 years ago
|
||
Verified as fixed in: Builds: Firefox for Android 33.0a2 (2014-08-12) Firefox for Android 34.0a1 (2014-08-11) Device: Kindle Fire HD 7"
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•