1037740 - Private Tabs verbiage is truncated on small tablet

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Richard Newman [:rnewman]]

Attachment: Screenshot

See attached screenshot.

Comment 1

[Richard Newman [:rnewman]]

Presumably these strings haven't been localized because they're recent…

Comment 2

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Worth noting that we're doing some adjustments to the private tabs panel in bug 1021356, including adding a ScrollView so that the text can be panned, so we should tackle the spacing for this bug after that one.

Comment 3

[Aaron Train [:aaronmt]]

This is in on Aurora now. Just saw this on trunk and found this bug. Tracking plz.

Comment 4

[Aaron Train [:aaronmt]]

(Saw this on my Nexus 7, 2013 fwiw)

Comment 5

[:Margaret Leibovic]

Is this still a problem? Do we want to tweak this design to improve readability?

Tracking 33 to make a decision about this.

Comment 6

[Richard Newman [:rnewman]]

Still happens on fx-team.

Comment 7

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

(In reply to :Margaret Leibovic from comment #5)
> Do we want to tweak this design to improve readability?

I don't believe I made small tablet specific styles for small tablet and it looks a bit goofy so I think it'd be worth making the change. I'll try to make it look more like phone and large tablet, unless Anthony has some additional feedback.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Attachment: Update empty private tabs panel styles for small tablet

Comment 9

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Attachment: After patch v1

Comment 10

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

The screenshat from comment 9 is from the Kobo Arc.

Comment 11

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8465784 [details]
After patch v1

I know we don't have a lot of space to work with here so I think this will do for now. Nicely done Michael!

Comment 12

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Comment on attachment 8465780 [details] [diff] [review]
Update empty private tabs panel styles for small tablet

bnicholson seems MIA.

Comment 13

[Wesley Johnston (:wesj)]

Comment on attachment 8465780 [details] [diff] [review]
Update empty private tabs panel styles for small tablet

Review of attachment 8465780 [details] [diff] [review]:
-----------------------------------------------------------------

How does this look in portrait? i.e. Do we want this to be landscape specific?

Comment 14

[Richard Newman [:rnewman]]

Portrait is where I saw the problem, FWIW.

Comment 15

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

(In reply to Wesley Johnston (:wesj) from comment #13)
> How does this look in portrait? i.e. Do we want this to be landscape
> specific?

I think you have portrait and landscape backwards, by the way.

Landscape uses the small side bar and doesn't have this issue.

Comment 16

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/cd118a9e2d18

Comment 17

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Comment on attachment 8465780 [details] [diff] [review]
Update empty private tabs panel styles for small tablet

Approval Request Comment
[Feature/regressing bug #]:
  Private tabs panel description

[User impact if declined]:
  Users will have an inconsistent experience where the look of the private tabs panel on small tablets changes between versions

[Describe test coverage new/current, TBPL]:
  Tested locally

[Risks and why]: 
  Low, we just changed styles specific to small tablet. Worst case, we further break the panel on small tablet.

[String/UUID change made/needed]: None

Comment 18

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cd118a9e2d18

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d63862ecf62b

Comment 20

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in:
Builds:
Firefox for Android 33.0a2 (2014-08-12)
Firefox for Android 34.0a1 (2014-08-11)

Device: Kindle Fire HD 7"