Closed Bug 1037740 Opened 5 years ago Closed 5 years ago

Private Tabs verbiage is truncated on small tablet

Categories

(Firefox for Android :: Theme and Visual Design, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 34
Tracking Status
firefox33 --- verified
firefox34 --- verified
fennec 33+ ---

People

(Reporter: rnewman, Assigned: mcomella)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Attached image Screenshot
See attached screenshot.
Blocks: kindle
Presumably these strings haven't been localized because they're recent…
Worth noting that we're doing some adjustments to the private tabs panel in bug 1021356, including adding a ScrollView so that the text can be panned, so we should tackle the spacing for this bug after that one.
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
Depends on: 1021356
This is in on Aurora now. Just saw this on trunk and found this bug. Tracking plz.
tracking-fennec: --- → ?
(Saw this on my Nexus 7, 2013 fwiw)
Is this still a problem? Do we want to tweak this design to improve readability?

Tracking 33 to make a decision about this.
tracking-fennec: ? → 33+
Flags: needinfo?(michael.l.comella)
Flags: needinfo?(alam)
Still happens on fx-team.
(In reply to :Margaret Leibovic from comment #5)
> Do we want to tweak this design to improve readability?

I don't believe I made small tablet specific styles for small tablet and it looks a bit goofy so I think it'd be worth making the change. I'll try to make it look more like phone and large tablet, unless Anthony has some additional feedback.
Flags: needinfo?(michael.l.comella)
Attached image After patch v1
Attachment #8465784 - Flags: feedback?(alam)
The screenshat from comment 9 is from the Kobo Arc.
Comment on attachment 8465784 [details]
After patch v1

I know we don't have a lot of space to work with here so I think this will do for now. Nicely done Michael!
Attachment #8465784 - Flags: feedback?(alam) → feedback+
Flags: needinfo?(alam)
Comment on attachment 8465780 [details] [diff] [review]
Update empty private tabs panel styles for small tablet

bnicholson seems MIA.
Attachment #8465780 - Flags: review?(bnicholson) → review?(wjohnston)
Comment on attachment 8465780 [details] [diff] [review]
Update empty private tabs panel styles for small tablet

Review of attachment 8465780 [details] [diff] [review]:
-----------------------------------------------------------------

How does this look in portrait? i.e. Do we want this to be landscape specific?
Attachment #8465780 - Flags: review?(wjohnston) → review+
Portrait is where I saw the problem, FWIW.
(In reply to Wesley Johnston (:wesj) from comment #13)
> How does this look in portrait? i.e. Do we want this to be landscape
> specific?

I think you have portrait and landscape backwards, by the way.

Landscape uses the small side bar and doesn't have this issue.
Comment on attachment 8465780 [details] [diff] [review]
Update empty private tabs panel styles for small tablet

Approval Request Comment
[Feature/regressing bug #]:
  Private tabs panel description

[User impact if declined]:
  Users will have an inconsistent experience where the look of the private tabs panel on small tablets changes between versions

[Describe test coverage new/current, TBPL]:
  Tested locally

[Risks and why]: 
  Low, we just changed styles specific to small tablet. Worst case, we further break the panel on small tablet.

[String/UUID change made/needed]: None
Attachment #8465780 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/cd118a9e2d18
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Attachment #8465780 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed in:
Builds:
Firefox for Android 33.0a2 (2014-08-12)
Firefox for Android 34.0a1 (2014-08-11)

Device: Kindle Fire HD 7"
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.