Closed Bug 103779 Opened 24 years ago Closed 24 years ago

GetWindowsFolder leaks a string

Categories

(Core :: XPCOM, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: Bienvenu, Assigned: Bienvenu)

References

Details

(Keywords: memory-leak)

Attachments

(1 file)

GetWindowsFolder in nsSpecialSystemDirectory leaks a string by duping it and assigning the dup to an nsFileSpec &, which leaks the dup, since nsFileSpec copies the data anyway. Patch upcoming.
can I get reviews from doug and seth? thanks.
Keywords: mlk
Attached patch proposed fixSplinter Review
Comment on attachment 52659 [details] [diff] [review] proposed fix sr=sspitzer
Attachment #52659 - Flags: superreview+
Comment on attachment 52659 [details] [diff] [review] proposed fix looks good.
Attachment #52659 - Flags: review+
*** Bug 94064 has been marked as a duplicate of this bug. ***
fixed.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
How big was this leak? I filed bug 102828, which is very similar.
*** Bug 102828 has been marked as a duplicate of this bug. ***
yep, that was a dup - I dup'ed it.
QA Contact: scc → stephend
Verified FIXED with the latest CVS pull and Purify, with the following scenario from bug 102828 (which I filed). * Launching mozilla.exe -mail with 1 POP3 server, with 2 new messages. * Login at startup and saved password selected. * Didn't actually read mail, just let biff notify me of new messages
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: