1037962 - [DSDS] "SIM x:" hardcoded in Settings and System

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Théo Chevalier]

In settings > Device information and More information screens, "SIM X:" are hardcoded (on Dual-SIM phones).

This is an issue for locales that translate "SIM" (like Tamil), and locales like French who require a different typography.

Comment 1

[Francesco Lodolo [:flod]]

It's even worse...

Grep of 'SIM ', which doesn't necessarily catch all of them
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/about.js#L87
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/about_more_info.js#L98
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/icc_menu.js#L77
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/simcard_manager_simcard_helper.js#L33

Comment 2

[Théo Chevalier]

Oh, good catch Flod :) So far I only fixed the first two links

Comment 3

[Francesco Lodolo [:flod]]

Plus a couple outside of settings.
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/icc_worker.js#L505
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/mobile_id/js/ui.js#L416

Comment 4

[Théo Chevalier]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21659

Let's see how many tests I broke :)

Note: I haven't been able to test the changes for ICC and Mobile ID (no idea how to test that).

However the changes for SIM Manager and Device information in Settings are working as expected.

Comment 6

[Delphine Lebédel [:delphine - Use needinfo]]

Update: this bug still occurs on 2.2 and 3.0 (see description in Dupe Bug 1142728)

Comment 7

[Delphine Lebédel [:delphine - Use needinfo]]

Nominating as blocker as this definitely needs to be localizable for our l10n teams: not all use "SIM". This really needs a fix

Comment 8

[Théo Chevalier]

Looks like it slightly fell off off my radar :) Feel free to steal the attached PR and work on it, I'll be a bit busy for some time.

Comment 9

[howie [:howie]]

Triage: blocking

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] crh0716:1037962 > mozilla-b2g:master

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8578581 [details] [review]
[gaia] crh0716:1037962 > mozilla-b2g:master

The patch tires to clean the hard coded sim related strings. EJ, Alive, could you help review the patch? Thanks.

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8578581 [details] [review]
[gaia] crh0716:1037962 > mozilla-b2g:master

Thanks!

Comment 13

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8578581 [details] [review]
[gaia] crh0716:1037962 > mozilla-b2g:master

Thanks Arthur, r+ if few comments are addressed.

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks, EJ.

master: 47553b644b46cdce781c7ad351e1d770aafd1f25

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8578581 [details] [review]
[gaia] crh0716:1037962 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: RTL issue.
[Testing completed]: Unit tests passed.
[Risk to taking this patch] (and alternatives if risky): Low as it is simple replacement.
[String changes made]: Yes. Three new strings were added:
  System:
    simLabel=SIM {{id}}
    icc-notification-title=SIM {{id}} STK
  Settings:
    simWithIndex = SIM {{index}}

Comment 16

[(PTO June 19-July 7) Ryan VanderMeulen]

v2.2: https://github.com/mozilla-b2g/gaia/commit/5fead741f571ee5e3c98013ad1803a80c4630a80

Comment 17

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame v2.2&2.5&master and Aries KK v2.5&master by the STR in comment 0 of Bug 1142728 and comment 0. 

Actual results: The "SIM X" shows correctly in Settings->SIM manager, and in Settings->Device information and More information screens.
See attachment: verified_Flame_v2.5.png
Reproduce rate: 0/10


Device: Flame master_512mb eng (Pass)
Build ID               20151208150206
Gaia Revision          6b430ea7274af4c352de16b75e6bb85d7621ca83
Gaia Date              2015-12-08 06:31:07
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a8965ae93c5d098a4f91ad9da72150bb43df07a7
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151208.183034
Firmware Date          Tue Dec  8 18:30:47 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master eng (Pass)
Build ID               20151208222037
Gaia Revision          6b430ea7274af4c352de16b75e6bb85d7621ca83
Gaia Date              2015-12-08 06:31:07
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a8965ae93c5d098a4f91ad9da72150bb43df07a7
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151208.213715
Firmware Date          Tue Dec  8 21:37:23 UTC 2015
Bootloader             s1

Device: Flame v2.5_512mb user (Pass)
Build ID               20151208120554
Gaia Revision          2d54c29f429bed790b5d8284633812dc2b782518
Gaia Date              2015-12-02 14:41:15
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ff31a251b2f6149edf4fc0a199133ef2e190ceac
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151208.111719
Firmware Date          Tue Dec  8 11:17:29 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK v2.5 dogfood (Pass)
Build ID               20151208121136
Gaia Revision          2d54c29f429bed790b5d8284633812dc2b782518
Gaia Date              2015-12-02 14:41:15
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ff31a251b2f6149edf4fc0a199133ef2e190ceac
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151208.111803
Firmware Date          Tue Dec  8 11:18:12 UTC 2015
Bootloader             s1

Device: Flame 2.2_512mb (Pass) 
Build ID               20151208032501
Gaia Revision          885647d92208fb67574ced44004ab2f29d23cb45
Gaia Date              2015-10-07 13:05:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4381c4b69b9c
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151208.072538
Firmware Date          Tue Dec  8 07:25:49 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 18

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame v2.2&2.5&master by the STR in comment 0 of Bug 1142728 and comment 0. 

Actual results: The "SIM X" shows correctly in Settings->SIM manager, and in Settings->Device information and More information screens.
See attachment: verified_Flame_v2.5.png
Reproduce rate: 0/10


Device: Flame master_512mb eng (Pass)
Build ID               20151208150206
Gaia Revision          6b430ea7274af4c352de16b75e6bb85d7621ca83
Gaia Date              2015-12-08 06:31:07
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a8965ae93c5d098a4f91ad9da72150bb43df07a7
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151208.183034
Firmware Date          Tue Dec  8 18:30:47 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame v2.5_512mb user (Pass)
Build ID               20151208120554
Gaia Revision          2d54c29f429bed790b5d8284633812dc2b782518
Gaia Date              2015-12-02 14:41:15
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ff31a251b2f6149edf4fc0a199133ef2e190ceac
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151208.111719
Firmware Date          Tue Dec  8 11:17:29 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame 2.2_512mb (Pass) 
Build ID               20151208032501
Gaia Revision          885647d92208fb67574ced44004ab2f29d23cb45
Gaia Date              2015-10-07 13:05:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4381c4b69b9c
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151208.072538
Firmware Date          Tue Dec  8 07:25:49 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 19

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.5.png