1037979 - Connection Timer should be more that five seconds

Status: VERIFIED FIXED

(Hello (Loop) :: Server, defect)

Description

[José Antonio Olivera Ortega [:jaoo]]

The connection timer defined at [1] should be more that five seconds. The call setup state does not reach "connected" quite often in this time period. What about ten seconds?


[1] https://wiki.mozilla.org/Loop/Architecture/MVP#WebSockets_Connection_for_Call_Progress

Comment 1

[Adam Roach [:abr]]

I'm okay increasing this to 10 seconds, but I'm really perplexed about why it would take so long. We should collect telemetry to find out what the actual times are between "connecting" and "connected" are. I know this is difficult on the mobile client, but we should be able to collect it on at least the desktop client.

I'll adjust the documentation accordingly.

Comment 2

[Rémy Hubscher (:natim)]

Attachment: Link to github PR

Comment 3

[Rémy Hubscher (:natim)]

I have made the default config be 10 accordingly.

Comment 4

[Alexis Metaireau (:alexis)]

Same comment as Adam, I wonder why 5 seconds isn't enough to connect here. What's taking so long?

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Alexis Metaireau (:alexis) from comment #4)
> Same comment as Adam, I wonder why 5 seconds isn't enough to connect here.
> What's taking so long?

Once the client reaches 'connecting' state it starts publishing the A/V streams. See the code at [1] please. The client sends the 'media-up' message once the completion handler of Session.publish() (see [2]) gets called. The time in between is usually bigger than 5 seconds. Sometime it isn't though. 

[1] https://github.com/mozilla-b2g/firefoxos-loop-client/blob/master/call_screen/js/call_manager.js#L28-L43
[2] http://tokbox.com/opentok/libraries/client/js/reference/Session.html#publish

Comment 6

[Alexis Metaireau (:alexis)]

https://github.com/mozilla-services/loop-server/commit/9b269863ff1183fc72c23eca70d265f8cc56fb28

Comment 7

[James Bonacci [:jbonacci]]

Verified in code.