103805 - xpti needs support for 'additionalManagers'

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[John Bandhauer]

The WebApps WSDL based SOAP support requires additional dynamic implementations 
of nsIInterfaceInfoManager. In order to have a centralized place to *find* them 
we decided to extend the singleton xpti service to also implement an interface 
for adding, removing, and enumerating the additional dynamic implementations. We 
want that collection point to support weak references. We anticipate the 
posibility that other systems may also want to use that collection point.

I'll attach an untested implementation.

Comment 1

[John Bandhauer]

Attachment: untested implementation

Comment 2

[vidur (gone)]

Comment on attachment 52687 [details] [diff] [review]
untested implementation

A couple of problems:
1) To get a weak reference, use do_GetWeakReference (which QIs to nsISupportsWeakReference and gets the weak reference from it).
2) enumerateAdditionManagers -> enumerateAdditionalManagers.
3) AppendElement on the enumerator class returns a PRBool, but you're treating it as a nsresult.

Comment 3

[John Bandhauer]

Thanks Vidur. Attaching new patch.

Comment 4

[John Bandhauer]

Attachment: better untested patch

Comment 5

[John Bandhauer]

Attachment: fresher patch

Comment 6

[John Bandhauer]

->0.9.8

Comment 7

[John Bandhauer]

Attachment: yet another refresh

Comment 8

[vidur (gone)]

Comment on attachment 65110 [details] [diff] [review]
yet another refresh

sr=vidur

Comment 9

[David Bradley]

Comment on attachment 65110 [details] [diff] [review]
yet another refresh

r=dbradley

I wanted to make sure I understood a couple of things. The additional managers
are held by the mAdditionalManagers array by weak references if they support
weak references, otherwise it's a norma ref  counted pointer. And the
enumerator always has ref counted pointer to the managers, so that they're
guarenteed to be alive during the enumerators lifetime.

Comment 10

[John Bandhauer]

Yes, exactly. Thanks.

Comment 11

[John Bandhauer]

patch checked in.