If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Change all IMEI in all testvars files to be an array with one or both IMEI codes.

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: zac, Assigned: dwong)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
In order to be able to test with dual IMEI numbers we need to update the testvars files to be an array.
(In reply to Zac C (:zac) from comment #0)
> In order to be able to test with dual IMEI numbers we need to update the
> testvars files to be an array.

This has to be done manually since there is no way to do this automatically.I'll have to take all the phones down to do this at a sitting. We should have kept the dual IMEI pull requests i submitted earlier.
Assignee: nobody → dwong
(Assignee)

Comment 2

3 years ago
Created attachment 8455658 [details] [review]
PR to change all testvars to use arrays for IMEI's
Attachment #8455658 - Flags: review?(zcampbell)
(In reply to Dylan Chun Wong [:dwong] from comment #2)
> Created attachment 8455658 [details] [review]
> PR to change all testvars to use arrays for IMEI's

Zac, can you take a look at the pull request since this changes for the Hamachi's as well,
Flags: needinfo?(zcampbell)
(Reporter)

Comment 4

3 years ago
Sure, I've already lined up test changes to deal with the 'data model' changes.
Flags: needinfo?(zcampbell)
(Reporter)

Comment 5

3 years ago
Merged!
https://github.com/mozilla/webqa-credentials/commit/ef3a910070c2d1145a1bb383fa7657f8a725ca75

Thanks Dylan for your hard work on this.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Reporter)

Updated

3 years ago
Attachment #8455658 - Flags: review?(zcampbell) → review+
I looked over the PR and I see that in 2 of the files the imei list contains the same code twice.
The files in question are:
b2g-2.json
b2g-17.2.json
Status: RESOLVED → REOPENED
Flags: needinfo?(dwong)
Resolution: FIXED → ---
(In reply to Robert Chira [:RobertC] from comment #6)
> I looked over the PR and I see that in 2 of the files the imei list contains
> the same code twice.
> The files in question are:
> b2g-2.json
> b2g-17.2.json

Dwong can you please look at this?
(Assignee)

Comment 8

3 years ago
Created attachment 8456438 [details] [review]
PR to amend b2g-2 and b2g-17.2
Attachment #8456438 - Flags: review?(mozbugs.retornam)
Flags: needinfo?(dwong)
Attachment #8456438 - Flags: review?(mozbugs.retornam) → review+

Comment 9

3 years ago
Thanks guys!
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED

Comment 10

3 years ago
https://github.com/mozilla/webqa-credentials/commit/eb3597586fd41a95cdeaf66c208396223107bfe2
You need to log in before you can comment on or make changes to this bug.