1038083 - Notifications disabled on lockscreen still wake up screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect, P2)

Description

[Rubén Martín [:Nukeador] ❌ [away till Aug 31st]]

As a user I expect my screen not to wake up each time I get a notification if I have disabled notifications on the lockscreen.

Device: Flame, 2.0, aurora channel.

Comment 1

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

[Blocking Requested - why for this release]: Lack of consistency for multiple releases. 

I also had this issue on Aries[1].

[1] Build ID               20150704190733
Gaia Revision          dc6c18c0dea7af3c40bfff86c530fd877d899dc4
Gaia Date              2015-07-04 01:35:20
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/136c41fca853
Gecko Version          42.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150619.224059
Firmware Date          Fri Jun 19 22:41:08 UTC 2015
Bootloader             s1

Comment 2

[Mahendra Potharaju [:mahe]]

Bad user experience. So, nominated for 2.5

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The related code lives screen mgmt. Lock screen don't wake screen up.

(In reply to Mahendra Potharaju [:mahe] from comment #2)
> Bad user experience. So, nominated for 2.5

Why for this release?

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

As per Comment 1, this is a regression that occurred.  Possibly due to the lockscreen changes that have gone and this escaped testing.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #4)
> As per Comment 1, this is a regression that occurred.  Possibly due to the
> lockscreen changes that have gone and this escaped testing.

Can we find out the regressed range if that's the case? I am not convinced based on the current flag on this bug.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Screen is turned on from notification_screen.js

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] timdream:notification-no-screenon > mozilla-b2g:master

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8664660 [details] [review]
[gaia] timdream:notification-no-screenon > mozilla-b2g:master

It make no sense for non-engineers to throw it over from one component to another, so I've resolved the root cause and fixed directly. 

What's really frustrated to me is that there is just too much |if (... && ... || ..)| and nested and nested code block in this file, indicating that no one is care about this part of Gaia enough. This has prevented me from writing unit test for the code too.

Considering this is a blocker, I am asking for review of this patch as-is. Please ask someone else responsible to work on this part if anyone would like to see this gets improved.

Comment 9

[Alberto Pastor [:albertopq]]

Comment on attachment 8664660 [details] [review]
[gaia] timdream:notification-no-screenon > mozilla-b2g:master

Yeah, this really needs a refactor. r=me after creating a bug for tracking the refactor. Thanks!

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

bug 1207493 filed.

master: https://github.com/mozilla-b2g/gaia/commit/7487e15e4ee76bf8684148db51ff3fc1ea752a9a

Comment 11

[Queena.Wen(Leave from Mozilla)]

This bug has been verified as "pass" on the latest build of Arise KK v2.5&Flame KK v2.5.

STR:
1.Disable the "show on lock screen" in the notifications setting.
2.Lock the phone.
3.Send a message to the test device.
4.Wait for 30 seconds, then unlock the phone.
5.Launch the message app.

Actual results: 3.The screen of the test device keeps sleep.
                5.The test device shows the received message. 

See attachment: Verified_AriseKK_v2.5.3gp

Reproduce rate: 0/10

Device: AriesKK v2.5(Pass)
Build ID               20150929001133
Gaia Revision          4c0a6d4e8501368db8e5d6029a41db985ef1252a
Gaia Date              2015-09-28 13:57:41
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/79a5b2968d01512470eb6c25d6638d8b9565575e
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150928.232925
Firmware Date          Mon Sep 28 23:29:34 UTC 2015
Bootloader             s1

Device: Flame KK 2.5(Pass)
Build ID               20150928150204
Gaia Revision          01ffe82cf088ca8fda9fe6783dc5cad2c3dde01c
Gaia Date              2015-09-28 08:49:32
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/031db40e2b558c7e4dd0b4c565db4a992c1627c8
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150928.182514
Firmware Date          Mon Sep 28 18:25:26 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 12

[Queena.Wen(Leave from Mozilla)]

Attachment: Verified_AriseKK_v2.5.3gp