Closed Bug 1038095 Opened 10 years ago Closed 10 years ago

Consider creating non-fat inline strings in ConcatStrings

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1105895

People

(Reporter: jandem, Unassigned)

References

Details

(Whiteboard: [Memshrink:P2])

ConcatStrings and the Ion string concat stub currently always create a fat-inline string if the result is short. With Latin1 strings, we can use a non-fat inline string if the length <= 15 (64-bit) or <= 7 (32-bit). We should instrument the browser to get some numbers, but it's probably common enough to be worth the extra branch.
I agree this is likely to be a good improvement.
Whiteboard: [Memshrink] → [Memshrink:P2]
njn just filed bug 1105895 and that one has a patch, so duping forward.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.