1038254 - Clicking input field in 2.x Simulator for Windows crashes

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Simulator, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

STR:

1. Create a new app in WebIDE from the "Privileged Empty App" template
2. Add an text input field
3. Deploy to 2.x simulator
4. Click the input field... Crash!

I'll attempt to get a debug simulator running so we can have a stack.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

In bug 945152, support for memory-mapped array buffers was added, and that is used by the Keyboard app to load its dictionaries.

However, that is not implemented on Windows for the moment (bug 988813).

So for now, we should disable this by turning off the pref "dom.mapped_arraybuffer.enabled" on Windows.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Disable memory-mapped array buffers on Windows

Fabrice, this disables memory-mapped array buffers on Windows, since they aren't implemented there currently (which in turn crashes the simulator when the keyboard opens).

Try: https://tbpl.mozilla.org/?tree=Try&rev=f8a41ff42728

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 8455697 [details] [diff] [review]
Disable memory-mapped array buffers on Windows

Review of attachment 8455697 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/app/b2g.js
@@ +1016,2 @@
>  pref("dom.mapped_arraybuffer.enabled", true);
> +#endif

Hm, that wont prevent crashes on other products...
Can you instead set it to false by default in all.js and here just do:

#ifndef XP_WIN
pref("dom.mapped_arraybuffer.enabled", true);
#endif

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Disable memory-mapped array buffers on Windows (v2)

Updated per review comments.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://tbpl.mozilla.org/?tree=Try&rev=1e96f5727611

Comment 6

[[:fabrice] Fabrice Desré]

Comment on attachment 8456410 [details] [diff] [review]
Disable memory-mapped array buffers on Windows (v2)

Review of attachment 8456410 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/app/b2g.js
@@ +1008,5 @@
>  
>  // Mobile Identity API.
>  pref("services.mobileid.server.uri", "https://msisdn-dev.stage.mozaws.net");
>  
>  // Enable mapped array buffer

nit: add a full stop at the end of the comment.

::: modules/libpref/src/init/all.js
@@ +4218,5 @@
>  
>  // DOM Inter-App Communication API.
>  pref("dom.inter-app-communication-api.enabled", false);
>  
> +// Disable mapped array buffer by default

nit: add a full stop at the end of the comment.

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Disable memory-mapped array buffers on Windows (v3, fabrice: r+)

Updated comments.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/ed58bb36345f

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ed58bb36345f

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8457714 [details] [diff] [review]
Disable memory-mapped array buffers on Windows (v3, fabrice: r+)

Approval Request Comment
[Feature/regressing bug #]: bug 945152 did not account for b2g desktop on Windows
[User impact if declined]: Text inputs crash the b2g 2.0 Simulator (which is built from the Aurora tree) on Windows
[Describe test coverage new/current, TBPL]: on m-c
[Risks and why]: Low, only toggling a pref
[String/UUID change made/needed]: None

Comment 11

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8457714 [details] [diff] [review]
Disable memory-mapped array buffers on Windows (v3, fabrice: r+)

Approval Request Comment
[Feature/regressing bug #]: bug 945152 did not account for b2g desktop on Windows
[User impact if declined]: Text inputs crash the b2g 2.0 Simulator (which is built from the Beta tree) on Windows
[Describe test coverage new/current, TBPL]: on m-c
[Risks and why]: Low, only toggling a pref
[String/UUID change made/needed]: None

Comment 12

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8457714 [details] [diff] [review]
Disable memory-mapped array buffers on Windows (v3, fabrice: r+)

I confirmed with jryans that this change does not impact b2g devices. It is restricted to the simulator. B2G 2.0 is now on the b2g30 branch. Clearing the aurora and beta noms and approving for b2g32 (current 2.0 branch).

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/a3f4a0a3dd68

Comment 14

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I've now released Simulator builds 2.0.20140724 and 2.1.20140724 to resolve this issue.