Closed Bug 1038259 Opened 6 years ago Closed 6 years ago

Enable template strings in all builds

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34
Tracking Status
relnote-firefox --- 34+

People

(Reporter: gupta.rajagopal, Assigned: gupta.rajagopal)

References

Details

(Keywords: dev-doc-complete)

Attachments

(2 files, 1 obsolete file)

Template strings functionality is hidden behind an ifdef flag. Remove the flag and enable the feature in all builds.
Attachment #8465605 - Flags: review?(jorendorff)
Status: NEW → ASSIGNED
Blocks: 688857
Comment on attachment 8465605 [details] [diff] [review]
Patch to enable template strings in all builds v1

Review of attachment 8465605 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/frontend/TokenStream.cpp
@@ +1754,2 @@
>          (*tp)->type = TOK_STRING;
> +    else {

Style nit: Keep the curly braces. (According to the house style, if any clause in an if-else chain gets braces, they all do.)
Attachment #8465605 - Flags: review?(jorendorff) → review+
Fixed nit.
Attachment #8465605 - Attachment is obsolete: true
Attachment #8465648 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/3d3945a8af7d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Release Note Request (optional, but appreciated)
[Why is this notable]: new ES6 feature
[Suggested wording]: Implemented & enabled JavaScript Template Strings
[Links (documentation, blog post, etc)]: TBD
relnote-firefox: --- → ?
Duplicate of this bug: 688857
Added in the 34 release notes "JavaScript Template Strings Implemented (docs)"
With docs pointing to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/template_strings
(which needs some love).
Keywords: dev-doc-needed
(In reply to Sylvestre Ledru [:sylvestre] from comment #9)
> Added in the 34 release notes "JavaScript Template Strings Implemented
> (docs)"
> With docs pointing to
> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/
> template_strings
> (which needs some love).

Thanks, I updated the docs to be more complete. Also mentioned on https://developer.mozilla.org/en-US/Firefox/Releases/34#JavaScript
After the Array.contains issues, I'm wary... can we use this in chrome code and rely on it shipping in 34? I didn't see an announcement about this feature on m.d.platform, but maybe I missed it?
Flags: needinfo?(jorendorff)
Discussed on IRC, http://logs.glob.uno/?c=mozilla%23developers&s=7+Oct+2014&e=7+Oct+2014#c1076183 onwards. TL,DR: use at own risk, in-tree usage will probably not kill anyone.
Flags: needinfo?(jorendorff)
Attached patch firefox.exeSplinter Review
You need to log in before you can comment on or make changes to this bug.