1038309 - SVG Images turns out fuzzy when gets rotated inside of other SVG

Status: RESOLVED WORKSFORME

(Core :: Graphics: ImageLib, defect)

Description

[David]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_4) AppleWebKit/537.77.4 (KHTML, like Gecko) Version/7.0.5 Safari/537.77.4

Steps to reproduce:

Rotate an SVG Image inside of other SVG, see http://jsfiddle.net/e66b8/4/ for test case.

<svg ...>
            <image xlink:ref="file.svg" transform="rotate(-24)" ...>
</svg>






Actual results:

The image is fuzzy or pixelated when gets rotated.


Expected results:

image should render correctly.

Comment 1

[Robert Longson [:longsonr]]

Attachment: reporter's testcase

Comment 2

[Alice0775 White]

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/4c2e31c6d4ef
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131118182715
Bad:
http://hg.mozilla.org/mozilla-central/rev/5236947f9090
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131118183211
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4c2e31c6d4ef&tochange=5236947f9090

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/3d3a8f13aa66
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131117233137
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/99108bac6f2d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131118003137
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3d3a8f13aa66&tochange=99108bac6f2d

Regressed by: Bug 923341

Comment 3

[Matt Woodrow (:mattwoodrow)]

I believe this regressed with http://hg.mozilla.org/integration/mozilla-inbound/rev/79cfed9c9d1d, and was already broken on non-windows platforms.

When there's no rotations involved, then we compute the final on-screen size of the svg and pass that into SVG drawing, but with rotations we give up [1] and tell the svg to draw at it's inner size (50x50 in this case).

Without caching of SVG's this doesn't matter, but with caching we'll rasterize the image at 50x50 (and insert it into the cache) and then scale it up when drawing to the screen.

I expect we want to still extract the 'scale factors' when a more complicated transform is present so we can avoid these scaling artifacts.

Want to work on this Seth?


[1] http://mxr.mozilla.org/mozilla-central/source/layout/base/nsLayoutUtils.cpp#4950

Comment 4

[Matt Woodrow (:mattwoodrow)]

Updated link for [1]: http://mxr.mozilla.org/mozilla-central/source/layout/base/nsLayoutUtils.cpp?rev=785acfd2ae48#5076

Comment 5

[Seth Fowler [:seth] [:s2h]]

So I expected this to be fixed by bug 1037713, but it's still busted. I'm going to needinfo myself to investigate this further. The infrastructure should be there to support this, but somehow we're not taking this transformation into account.

Comment 7

[mb]

any news or a work around until fixed? Thx a lot!

Comment 8

[David]

any news or update?, Thanks a lot!!

Comment 9

[Milan Sreckovic [:milan] (needinfo for best results)]

I'd wait another day and try the nightly build, once the fix for bug 1128467 is in.

Comment 10

[Ronald Tilby]

The reporter's testcase (images of Homer Simpson) look identical to me in Google Chrome and Firefox Nightly 49.0a1 (2016-05-21) on my Windows 10 desktop machine.

Comment 11

[Archil Imnadze]

Yes, it looks identical for me too. But please, take a look at the bug https://bugzilla.mozilla.org/show_bug.cgi?id=1112558 which I hope renders differently.