1038350 - Put fully packaged dev/stage apps in gaia

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, defect, P1)

Description

[Wil Clouser [:clouserw]]

Please land our new fully packaged dev and stage apps in the gaia tree, replacing whatever is there.

https://github.com/mozilla-b2g/gaia/tree/master/dev_apps/marketplace-dev.allizom.org
https://github.com/mozilla-b2g/gaia/tree/master/dev_apps/marketplace.allizom.org

Bonus points for making a PR against v2.0 also.  Ask me if there are questions, thanks.

Comment 1

[Kevin Ngo [:ngoke]]

v1.4: https://github.com/mozilla-b2g/gaia/pull/21722
v2.0: https://github.com/mozilla-b2g/gaia/pull/21723

Comment 2

[Wil Clouser [:clouserw]]

v1.4 is double bonus points, but we still need master too.  Thanks

Comment 3

[Kevin Ngo [:ngoke]]

Updated PRs with getting rid of data URIs and one on master. 

https://github.com/mozilla-b2g/gaia/pull/21726

Comment 4

[Wil Clouser [:clouserw]]

Attachment: new packages; v1.4

Comment 5

[Wil Clouser [:clouserw]]

Attachment: new packages; v2.0

Comment 6

[Wil Clouser [:clouserw]]

Attachment: new packages; master

Comment 7

[Wil Clouser [:clouserw]]

Fabrice offered to review the patches.  If they are valid, please land.  Thanks

Comment 8

[[:fabrice] Fabrice Desré]

I retriggered the tests on travis, but tbpl was very red too. Can you ask for review once this is all green? thanks!

Comment 9

[Wil Clouser [:clouserw]]

Kevin - looks like there is a syntax error. Eg. https://travis-ci.org/mozilla-b2g/gaia/jobs/29936026#L652

Comment 10

[Kevin Ngo [:ngoke]]

Updated my PRs, awaiting tests.

Comment 11

[Kevin Ngo [:ngoke]]

The PRs updated. The build is failing, but those errors don't look like mine. It should be okay to review now.

https://travis-ci.org/mozilla-b2g/gaia/builds/30212487

Comment 12

[[:fabrice] Fabrice Desré]

Hm, looking at https://tbpl.mozilla.org/?rev=1cbb850236a8693b4598cb486216947f275f6865&tree=Gaia-Try :

Exception: [Exception... "Component returned failure code: 0x8052000b (NS_ERROR_FILE_CORRUPTED) [nsIZipReader.open]" nsresult: "0x8052000b (NS_ERROR_FILE_CORRUPTED)" location: "JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> file:///builds/slave/test/gaia/build/utils-xpc.js :: readZipManifest :: line 163" data: no]

Are you sure it's not your package?

Comment 13

[Kevin Ngo [:ngoke]]

I've updated the PRs. There are still some build errors, I looked through all of them on tbpl and can't make much sense of them. Can you check if it's good? Thanks!

Comment 14

[Andy McKay]

I've looked at tbpl and the zip that Kevin posted and it's not clear what the problem is to me either.

Comment 15

[Wil Clouser [:clouserw]]

jhford and yuren are helping in bug 1011016.  I suspect it's all related.

Comment 16

[Wil Clouser [:clouserw]]

Yuren - can you help us with why this wouldn't work?  The above patches will fix bug 1011016 I think.

Comment 17

[Wil Clouser [:clouserw]]

Actually, looks like the above patches don't hit https://github.com/mozilla-b2g/gaia/tree/v1.4/test_external_apps/marketplace-dev.allizom.org which is where the problem is, but it would just be a matter of copying the files to that location.

Comment 18

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

looks all error happended on downloading firefox test package from http://ftp.mozilla.org.proxxy.srv.releng.usw2.mozilla.com/pub/mozilla.org/b2g/tinderbox-builds/mozilla-b2g30_v1_4-linux64_gecko/1406829431/en-US/b2g-30.0.en-US.linux-x86_64.tests.zip

but I'm not familiar with mozharness, :jhford, do you know what's going on?

Comment 19

[John Ford [:jhford] CET/CEST Berlin Time]

Yuren, I believe the thing causing that was backed out.  Can we retrigger that test?

Comment 20

[Andy McKay]

https://tbpl.mozilla.org/?rev=2c6389061e34d60cb66fa47fcf1b2f1d2332ee24&tree=Gaia-Try
https://tbpl.mozilla.org/?rev=54c218c3eb5c413dec39d541937c8f4fc77643b6&tree=Gaia-Try

One failure each in the Gb run. Getting closer!

Comment 21

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: gb.patch

Andy, this patch can solve build test issues both for v1.4 and v2.0.

Comment 22

[Wil Clouser [:clouserw]]

Thanks Yuren.  Kevin added your patch to the PRs.  They seem to be improving but are still failing.  Yuren & John - can you help?

1.4: https://tbpl.mozilla.org/?rev=0aebd3365108b366a4894b6a9a722f08d6d3e5d9&tree=Gaia-Try
2.0: https://tbpl.mozilla.org/?rev=a56bb2978358805dfae62f958668a42ef77d21bb&tree=Gaia-Try
master: https://tbpl.mozilla.org/?rev=2bb221e8ad71be52d6acf4bb6f841e023a0cdfe9&tree=Gaia-Try

Comment 23

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

looks we got green on last pr for 1.4.

Comment 24

[Wil Clouser [:clouserw]]

Comment on attachment 8455815 [details] [review]
new packages; v1.4

Please review and land.  Thanks.

Comment 25

[Wil Clouser [:clouserw]]

Comment on attachment 8455816 [details] [review]
new packages; v2.0

Please review and land.  Thanks.

Comment 26

[Wil Clouser [:clouserw]]

Comment on attachment 8455817 [details] [review]
new packages; master

Please review and land.  Thanks.

Comment 27

[Wil Clouser [:clouserw]]

(In reply to Yuren [:yurenju] from comment #23)
> looks we got green on last pr for 1.4.

Ah, I thought the red Gb meant tests still weren't passing.  Thanks for the help, r?ing fabrice to land.

Comment 28

[[:fabrice] Fabrice Desré]

Yuren, is it ok to land with the Gb failures?

Comment 29

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

no but we got Gb all green for all branches.

v1.4
https://tbpl.mozilla.org/?rev=2defd1682fd0e52c769417ad149541de3bb5cbc5&tree=Gaia-Try

v2.0 
https://tbpl.mozilla.org/?rev=a56bb2978358805dfae62f958668a42ef77d21bb&tree=Gaia-Try

master
https://tbpl.mozilla.org/?rev=2bb221e8ad71be52d6acf4bb6f841e023a0cdfe9&tree=Gaia-Try

Comment 30

[[:fabrice] Fabrice Desré]

Merged on 1.4: https://github.com/mozilla-b2g/gaia/commit/caae93c9b7624e43e9d12ce375a67ef98115be9a

Comment 31

[[:fabrice] Fabrice Desré]

2.0 and 2.1 are definitely burning. Yuren or Julien, can anyone take a look?

Comment 32

[Julien Wajsberg [:julienw]]

https://tbpl.mozilla.org/?tree=B2g-Inbound&showall=1&jobname=gaia- this looks green on 2.1 to me?

(note: I don't know much about Gb)

Comment 33

[[:fabrice] Fabrice Desré]

(In reply to Julien Wajsberg [:julienw] from comment #32)
> https://tbpl.mozilla.org/?tree=B2g-Inbound&showall=1&jobname=gaia- this
> looks green on 2.1 to me?

Look at the Gij perma fail on:
https://tbpl.mozilla.org/?rev=2bb221e8ad71be52d6acf4bb6f841e023a0cdfe9&tree=Gaia-Try

Comment 34

[Julien Wajsberg [:julienw]]

I don't see this failure on the current master pushes (but I see other failures though).

Kevin, maybe you can have a look?

Comment 35

[Kevin Grandon :kgrandon]

Can you try rebasing against master and pushing again? I feel that this test was broken and fixed after recently. I also don't see anything in PR that should cause it to fail. Thanks!

Comment 36

[Kevin Ngo [:ngoke]]

Rebased, the tests are kicking off now.

Comment 37

[Julien Wajsberg [:julienw]]

Looks greener

Comment 38

[[:fabrice] Fabrice Desré]

I think master is fine (the failure on the PR is due to something that was backed out yesterday evening), but 2.0 is still red on Gij:
https://tbpl.mozilla.org/?rev=f0a336dbaf0b83ac8238e423395651c65985f026&tree=Gaia-Try

Comment 39

[[:fabrice] Fabrice Desré]

Merged master: https://github.com/mozilla-b2g/gaia/commit/9f35fca9d818b26c06aa6b7e5c0bef25886f8f20

Comment 40

[Kevin Grandon :kgrandon]

Hmm, I don't really see how this patch could cause the failure in question. Additionally it looks like we don't even run Gij on Aurora currently. Seems fine to me that you should be able to land. Not sure what the process is regarding getting approval for stuff like this is.

Comment 41

[[:fabrice] Fabrice Desré]

2.0: https://github.com/mozilla-b2g/gaia/commit/7fdb37b8a6688ef39ceaa41b56c4a9339802e78e