1038518 - [Keyboard][Pinyin] Adjust Chinese comma and period positions visually center in the key width

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Comment 1

[[e-mail]]

Attachment: PinYin_revise_visual spec_0714.jpg

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I don't think this is doable without changing the font to use, also the convention of Simplified Chinese has always been putting the "。" punctuation at the buttom left corner. Suggesting closing this as WONTFIX or INVALID.

I will r- any patch that attempt to offset the position without actually changing the font. Such patch is harmful because it will be visually depend on a certain font.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

More info can be read at bug 1040621.

Comment 4

[Yuan Xulei [:yxl] (Leave from May 18)]

I agree with Tim that the patch should be font independent.

The Chinese Android IMEs, such as baidu or sogou IME, encountered the same issue. Their method to solve it is to render the button with images.

We may use the same method.

Comment 5

[[e-mail]]

That's a good choice for now, how do you think about it? @Tim

(In reply to Yuan Xulei [:yxl] from comment #4)
> I agree with Tim that the patch should be font independent.
> 
> The Chinese Android IMEs, such as baidu or sogou IME, encountered the same
> issue. Their method to solve it is to render the button with images.
> 
> We may use the same method.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to [e-mail] from comment #5)
> That's a good choice for now, how do you think about it? @Tim

If we are using image we will run into hi-dpi issue etc.... 

So my argument is that this shouldn't be a valid bug at first place. However, seems like according to you for artistic reason Baidu and Sogou IME put the circle on the center, so that probably this bug remains valid.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

So after talking to Mike offline on the requirement from visual team, and the realization of artistic reason in comment 6, I agree we can make a glyph-dependent adjustment for Flame and Flame only. However, before that, we should probably land bug 1040621 first and make the CSS position adjustment only targets zh-CN locale.

Thanks.

Comment 8

[BMO Automation]

Firefox OS is not being worked on