[Keyboard][Pinyin] Adjust Chinese comma and period positions visually center in the key width

RESOLVED WONTFIX

Status

Firefox OS
Gaia::Keyboard
RESOLVED WONTFIX
4 years ago
4 months ago

People

(Reporter: wdeng@mozilla.com, Assigned: wdeng@mozilla.com)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8455883 [details]
PinYin_revise_visual spec_0714.jpg
(Assignee)

Updated

4 years ago
Assignee: nobody → wdeng
(Assignee)

Updated

4 years ago
Blocks: 1021505
I don't think this is doable without changing the font to use, also the convention of Simplified Chinese has always been putting the "。" punctuation at the buttom left corner. Suggesting closing this as WONTFIX or INVALID.

I will r- any patch that attempt to offset the position without actually changing the font. Such patch is harmful because it will be visually depend on a certain font.
Flags: needinfo?(chuang)
More info can be read at bug 1040621.
I agree with Tim that the patch should be font independent.

The Chinese Android IMEs, such as baidu or sogou IME, encountered the same issue. Their method to solve it is to render the button with images.

We may use the same method.
(Assignee)

Comment 5

4 years ago
That's a good choice for now, how do you think about it? @Tim

(In reply to Yuan Xulei [:yxl] from comment #4)
> I agree with Tim that the patch should be font independent.
> 
> The Chinese Android IMEs, such as baidu or sogou IME, encountered the same
> issue. Their method to solve it is to render the button with images.
> 
> We may use the same method.
(In reply to wdeng@mozilla.com from comment #5)
> That's a good choice for now, how do you think about it? @Tim

If we are using image we will run into hi-dpi issue etc.... 

So my argument is that this shouldn't be a valid bug at first place. However, seems like according to you for artistic reason Baidu and Sogou IME put the circle on the center, so that probably this bug remains valid.
So after talking to Mike offline on the requirement from visual team, and the realization of artistic reason in comment 6, I agree we can make a glyph-dependent adjustment for Flame and Flame only. However, before that, we should probably land bug 1040621 first and make the CSS position adjustment only targets zh-CN locale.

Thanks.
Flags: needinfo?(chuang)

Comment 8

4 months ago
Firefox OS is not being worked on
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.