Closed Bug 1038615 Opened 8 years ago Closed 8 years ago

Report GMP decoding/encoding errors asynchronously

Categories

(Core :: Audio/Video, defect)

x86_64
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The functions on the GMPVideoDecoder interface have return values, but the return values are ignored by the plugin harness, and not returned to Gecko. The return valued can't be sent back to Gecko because the methods are defined to be async in the IPDL definitions. There also isn't any other way to report errors from the decoder or encoder to Gecko. So we should have a callback to report errors, and the return values of the functions on GMPVideoDecoder and friends should be void.
Attached patch PatchSplinter Review
Attachment #8456038 - Flags: review?(rjesup)
Attachment #8456038 - Flags: review?(rjesup)
Attachment #8456038 - Flags: review+
Attachment #8456038 - Flags: feedback?(ethanhugg)
Comment on attachment 8456038 [details] [diff] [review]
Patch

Review of attachment 8456038 [details] [diff] [review]:
-----------------------------------------------------------------

This should be fine.  I need some warning as to when this will land though it will break our compat and build system so I need to send out some notice and have our patches ready.   I assume you're targeting this for FF33.
Attachment #8456038 - Flags: feedback?(ethanhugg) → feedback+
Comment on attachment 8457439 [details] [diff] [review]
Patch to OpenH264 to match these changes

Review of attachment 8457439 [details] [diff] [review]:
-----------------------------------------------------------------

I will be proposing these changes into RBCommons when the FF patch hits M-C.  You can apply this diff onto openh264 master or if it's easier just pull the github/ethanhugg/gmpapi-errorchanges branch.  Adding jesup as feedback, but the formal review will be in rbcommons for OpenH264.
Attachment #8457439 - Flags: feedback?(rjesup)
https://hg.mozilla.org/mozilla-central/rev/fd72e28c6d38
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Attachment #8457439 - Flags: feedback?(rjesup)
You need to log in before you can comment on or make changes to this bug.