1038798 - Regression: After closing all tabs, tabs tray dotted menu can not be accessed again

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Currently, the tab-pane's dotted menu can not be accessed again after closing all tabs

Steps to Reproduce

  i. Launch Nightly
  ii. Open the tab drawer
  iii. Open the dotted menu, see 'Close All Tabs', tap 'Close All Tabs'
  iv. Open the tab drawer
  vi. Attempt to open the dotted menu again

--
Nightly (07/15)
LG Nexus 5 (Android 4.4.4)

Comment 1

[Aaron Train [:aaronmt]]

v. Profit?

Comment 2

[Aaron Train [:aaronmt]]

Last good revision: e1a037c085d1 (2014-07-11)
First bad revision: b0701d069bf9 (2014-07-12)

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e1a037c085d1&tochange=b0701d069bf9

The fx-team merge has:

63e2a9b4f650	Chenxia Liu — Bug 1028705 - Move new tab button back to the right. r=lucasr

Comment 3

[Chenxia Liu [:liuche]]

Attachment: Patch: Enable 3-dot menu button

Missed a setEnabled.

https://hg.mozilla.org/integration/fx-team/rev/63e2a9b4f650#l4.86

Comment 4

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/integration/fx-team/rev/61c29af88d35

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/61c29af88d35

Comment 6

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in
Builds:
Firefox for Android 33
Firefox for Android 34 Beta 4
Firefox for Android 35.0a2 (2014-11-03)
Firefox for Android 36.0a1 (2014-11-03)

Device:
Nexus 4 (Android 4.4.4)