Closed Bug 1038810 Opened 10 years ago Closed 10 years ago

[User Story] Single variant: Data roaming on/off by default customized by SIM

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.0+, b2g-v2.0 verified, b2g-v2.1 verified)

Status:
VERIFIED FIXED
Milestone:
2.1 S1 (1aug)
Project Flags:
blocking-b2g 2.0+
Tracking Flags:
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: sonmarce, Assigned: mai)

References

Details

(Whiteboard: [systemsfe])

User Story

As an Operator I want data roaming is on/off by default depending on the country, so that users get the usual local behavior

Acceptance criteria:
* Data roaming will be configured per each MCC/MNC after inserting a new SIM card for the first time
* There will be a default value for the case of data roaming is not configured for a MCC/MNC or no SIM card inserted
* Data roaming setting will not be replaced if SIM card is inserted after FTU to preserve user decision
* Replacing or removing SIM card later on will imply no change in data roaming configuration
* After a factory reset, data roaming will be configured the same way as a brand new device

Attachments

(1 file)

patch v1.0
46 bytes, text/x-github-pull-request
macajc
: review+
Details | Review 
See description in user story field
User Story: (updated)
Whiteboard: [systemsfe]
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Assignee: nobody → mri
Attached file patch v1.0 — 
Hi Carmen, 
would you mind reviewing the patch?
Regards
Attachment #8459506 - Flags: review?(carmen.jimenezcabezas)
Attachment #8459506 - Flags: review?(carmen.jimenezcabezas)
Comment on attachment 8459506 [details] [review]
patch v1.0

Hi Carmen, 
would you mind reviewing the patch?
Regards
Attachment #8459506 - Flags: review?(carmen.jimenezcabezas)
Good job, thanks. I've left some comments on github
Attachment #8459506 - Flags: review?(carmen.jimenezcabezas)
Comment on attachment 8459506 [details] [review]
patch v1.0

Updated the pr with your comments, could you review the patch again?
Regards
Attachment #8459506 - Flags: review?(carmen.jimenezcabezas)
Comment on attachment 8459506 [details] [review]
patch v1.0

Good job, thank you!
Attachment #8459506 - Flags: review?(carmen.jimenezcabezas) → review+
Master: 5458f73e319759543fddf7e96d7ece4d78318e32
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
status-b2g-v2.1: --- → fixed
Target Milestone: --- → 2.1 S1 (1aug)
Comment on attachment 8459506 [details] [review]
patch v1.0

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
It is required for certification by TEFs operators.
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): feature required for certification[User impact] if declined: roaming data cannot configured by default
[Testing completed]:yes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]:
Attachment #8459506 - Flags: approval-gaia-v2.0?(release-mgmt)
(In reply to marina rodríguez [:mai] from comment #7)
> Comment on attachment 8459506 [details] [review]
> patch v1.0
> 
> NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to
> better understand the B2G approval process and landings.
> It is required for certification by TEFs operators.
> [Approval Request Comment]
> [Bug caused by] (feature/regressing bug #): feature required for
> certification[User impact] if declined: roaming data cannot configured by
> default
> [Testing completed]:yes
> [Risk to taking this patch] (and alternatives if risky): Low
> [String changes made]:

Blocking on this given this is a cert blocker.
blocking-b2g: --- → 2.0+
Comment on attachment 8459506 [details] [review]
patch v1.0

The blocking 2.0+ will take care of landing this on 2.0.
Attachment #8459506 - Flags: approval-gaia-v2.0?(release-mgmt)
Testes and working
Flame
2.1
Gecko 46c9b03
Gaia 80a452a

2.0
Gecko d06b44a
Gaia 73fe34d
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: