1038832 - Urls should not be shown in the call log for direct calls

Status: RESOLVED FIXED

(Hello (Loop) :: Server, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

Attachment: 2014-07-15-19-07-26.png

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

This one's on the server side. We are getting the callUrl on a id to id call when we are not supposed get it:

{"calls":[{"callId":"a87873b71470b54dc1f9f685ddfaa39f","callType":"audio-video","callerId":"[e-mail]","websocketToken":"0a2685faccac3892ebcb8130f0d34b78","apiKey":"44669102","sessionId":"2_MX40NDY2OTEwMn5-U2F0IEp1bCAxOSAwNDoxNjo1MCBQRFQgMjAxNH4wLjg5NjA2MzI3flB-","sessionToken":"T1==cGFydG5lcl9pZD00NDY2OTEwMiZzaWc9MGRhNmRiZDEyZmNiZGZiMTk5ZGYwNWQ2OGZhZjMzZjdhYzM0NDM3ZTpzZXNzaW9uX2lkPTJfTVg0ME5EWTJPVEV3TW41LVUyRjBJRXAxYkNBeE9TQXdORG94TmpvMU1DQlFSRlFnTWpBeE5INHdMamc1TmpBMk16STNmbEItJmNyZWF0ZV90aW1lPTE0MDU3Njg2MDcmbm9uY2U9MC43NTQyMzI5NjEyMTg4MDQxJnJvbGU9cHVibGlzaGVyJmV4cGlyZV90aW1lPTE0MDU4NTUwMDc=","callUrl":"http://loop-webapp.dev.mozaws.net/#call/undefined","call_url":"http://loop-webapp.dev.mozaws.net/#call/undefined","progressURL":"ws://loop.dev.mozaws.net/websocket"}]}

Note the "call_url":"http://loop-webapp.dev.mozaws.net/#call/undefined"

Comment 2

[Rémy Hubscher (:natim)]

Attachment: Link to github PR

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8459454 [details]
Link to github PR

Thanks Rémy. I was just writing the tests for that very same fix.

Comment 4

[Alexis Metaireau (:alexis)]

Comment on attachment 8459454 [details]
Link to github PR

Looks good, with nits addressed.

Comment 5

[Rémy Hubscher (:natim)]

Oups :ferjm sorry about that I should have let you finish then :(

Comment 6

[Rémy Hubscher (:natim)]

https://github.com/mozilla-services/loop-server/commit/25721f08a9181cf7670c67be6ae1a7b30592ebfd

Comment 7

[James Bonacci [:jbonacci]]

Where are these call logs located?
I can verify the server-side changes, but how do we verify the call logs?

Comment 8

[Maria Angeles Oteo (:oteo)]

(In reply to James Bonacci [:jbonacci] from comment #7)
> Where are these call logs located?
> I can verify the server-side changes, but how do we verify the call logs?

I suppose that with the Loop Mobile client application available in  https://github.com/mozilla-b2g/firefoxos-loop-client

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

What :oteo said

Comment 10

[James Bonacci [:jbonacci]]

:natim
Maybe I am missing something in the commit from Comment 6, but where are the changes to loop/index.js?
This file appears to only have 188 lines in it now. Ah, so much has changed since July 21!
I was able to verify the changes for test/functional_test.js.

Comment 11

[Rémy Hubscher (:natim)]

James, `call log` here is the result of the API call to *GET /calls*

With this fix we are making sure we don't return some information for direct calls that we want to keep for URL initiated calls.